Make minimal button group divider modifier-independent #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
reviewed
Mar 30, 2017
| @@ -148,7 +148,8 @@ Styleguide components.button-group.css | |||
| @include pt-button-minimal-divider(); | |||
| display: inline-block; | |||
| position: absolute; | |||
| top: 0; | |||
| top: 10%; | |||
| bottom: 10%; | |||
There was a problem hiding this comment.
why percentage instead of pixel offset? i'd expect top/bottom: $pt-grid-size to look good in these cases.
There was a problem hiding this comment.
Nope, this becomes too small in the non large use case. Percentage works and is adapting its height no matter the button size
giladgray
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910
Now works well with
pt-minimal,pt-large,pt-verticalor any combination of these.Reviewers should focus on:
The general approach to the solution
Screenshot
Before:
After:
