Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagopa 1011 creazione schedule per lettura table e aggiornamento file xml #226

Merged
merged 22 commits into from
Jun 22, 2023
Merged

Pagopa 1011 creazione schedule per lettura table e aggiornamento file xml #226

merged 22 commits into from
Jun 22, 2023

Conversation

FedericoRuzzier
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier commented Jun 20, 2023 •
edited
Loading

List of Changes

Adding scheduler to update the ica binary file table accordingly to the design review, creating the xml and inserting it in the corresponding table.
PR tied to pagopa/pagopa-api-config-starter#23

Motivation and Context

This was needed due the iban refactoring. It will be dismissed with the dismissal of the ICA

How Has This Been Tested?

This has been tested manually using the h2 profile and with junit

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the enhancement New feature or request label Jun 20, 2023
@github-actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, minor, major, skip]

@FedericoRuzzier FedericoRuzzier mentioned this pull request Jun 20, 2023
Merged
5 tasks
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@FedericoRuzzier
Copy link
Contributor Author

update_code

@FedericoRuzzier FedericoRuzzier changed the title Pagopa 1011 creazione function per lettura e aggiornamento file xml Pagopa 1011 creazione schedule per lettura table e aggiornamento file xml Jun 21, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

jacopocarlini
jacopocarlini approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@FedericoRuzzier FedericoRuzzier merged commit 20aca53 into main Jun 22, 2023
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-1011-creazione-function-per-lettura-e-aggiornamento-file-xml branch June 22, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

Assignees

@FedericoRuzzier FedericoRuzzier

Labels
enhancement New feature or request minor size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FedericoRuzzier @jacopocarlini