Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagopa 1011 creazione function per lettura e aggiornamento file xml #23

Conversation

FedericoRuzzier
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier commented Jun 20, 2023

List of Changes

Adding modification to the ica binary file an related entity: ica binary file is now an isolated table, with a field that connects it to the creditor institution. Every EC will have a single ica binary file.
PR tied to pagopa/pagopa-api-config#226

Motivation and Context

This change was required due to the scheduler implementation in core

How Has This Been Tested?

This has been tested through h2 and junit

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the enhancement New feature or request label Jun 20, 2023
@github-actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, skip]

@FedericoRuzzier
Copy link
Contributor Author

update_code

@github-actions
Copy link

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@FedericoRuzzier FedericoRuzzier merged commit 7d4dc22 into main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants