-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMN-763 + IMN-764 - API Gateway - GET /purposes
+ GET /purposes/:purposeId
#793
Closed
ecamellini
wants to merge
1,128
commits into
IMN-745-api-gateway-get-agreement-purposes
from
IMN-763-api-gateway-get-purposes
Closed
IMN-763 + IMN-764 - API Gateway - GET /purposes
+ GET /purposes/:purposeId
#793
ecamellini
wants to merge
1,128
commits into
IMN-745-api-gateway-get-agreement-purposes
from
IMN-763-api-gateway-get-purposes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com> Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it>
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it> Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com> Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com> Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it> Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com> Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
ecamellini
changed the base branch from
main
to
IMN-745-api-gateway-get-agreement-purposes
July 25, 2024 09:33
ecamellini
changed the title
IMN-763 - API Gateway - GET
IMN-763 + IMN-764 - API Gateway - GET Jul 25, 2024
/purposes
/purposes
+ GET /purposes/{purposeId}
ecamellini
changed the title
IMN-763 + IMN-764 - API Gateway - GET
IMN-763 + IMN-764 - API Gateway - GET Jul 25, 2024
/purposes
+ GET /purposes/{purposeId}
/purposes
+ GET /purposes/:purposeId
ecamellini
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
July 25, 2024 14:05
MalpenZibo
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
packages/api-gateway/.env
Outdated
@@ -5,6 +5,7 @@ LOG_LEVEL=info | |||
WELL_KNOWN_URLS="https://dev.interop.pagopa.it/.well-known/jwks.json" | |||
ACCEPTED_AUDIENCES="dev.interop.pagopa.it/m2m,refactor.dev.interop.pagopa.it/m2m" | |||
|
|||
CATALOG_PROCESS_URL="http://localhost:3000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remember to change this configuration after merging #796
AsterITA
force-pushed
the
IMN-745-api-gateway-get-agreement-purposes
branch
from
July 29, 2024 08:57
fa02a85
to
40ae9c7
Compare
AsterITA
force-pushed
the
IMN-763-api-gateway-get-purposes
branch
from
July 29, 2024 08:57
5d8b795
to
346d8de
Compare
ecamellini
force-pushed
the
IMN-745-api-gateway-get-agreement-purposes
branch
from
August 12, 2024 08:53
40ae9c7
to
fa02a85
Compare
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-763
Closes IMN-764
Based on #783
GET
/purposes
success ✅GET
/purpose/:purposeId
success ✅Error cases
Trying to get a Purpose with no active version ❌
Purpose not found ❌
Forbidden because caller is not the purpose consumer or the eservice producer