Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMN-763 + IMN-764 - API Gateway - GET /purposes + GET /purposes/:purposeId #793

Closed
wants to merge 1,128 commits into from
Closed

IMN-763 + IMN-764 - API Gateway - GET /purposes + GET /purposes/:purposeId #793

wants to merge 1,128 commits into from

Conversation

ecamellini
Copy link
Collaborator

@ecamellini ecamellini commented Jul 25, 2024 •
edited
Loading

Closes IMN-763
Closes IMN-764
Based on #783

GET /purposes success ✅

image

GET /purpose/:purposeId success ✅

image

Error cases

Trying to get a Purpose with no active version ❌

image image

Purpose not found ❌

image

Forbidden because caller is not the purpose consumer or the eservice producer

image

galales and others added 30 commits June 3, 2024 11:24
@galales
feat: Enable renovate dashboard (#592)
edc3bf5
@AsterITA
IMN-451: retrieve latest risk analysis in purpose-process (#476)
492b6e1
@Viktor-K
Fix: submit agreement create contract only during first activation (#589
eb79831 
)
@renovate-pagopa
Update docker/build-push-action digest to ca052bb (#598)
1f4c253 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
@renovate-pagopa @micdes-pagopa
Update docker/metadata-action digest to f7b4ed1 (#600)
b447657 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
@ecamellini
IMN-590 - Fixing suspendedByPlatform flag inconsistencies (#578)
719ab07
@MalpenZibo
IMN 588 - Add agreement services return value test (#579)
c589a46
@rGregnanin
IMN-530 Refactor Test- Purpose (#507)
55c40ee
@rGregnanin
IMN-530 refactor purpose test pt2 (#511)
3de72c0
@MalpenZibo @micdes-pagopa
IMN 495 - Add consumer refresh token (#577)
55d1edf 
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
@Carminepo2 @taglioni-r
IMN-467 - Authorization updater purpose integrations (#418)
ffa2290 
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it>
@Carminepo2 @taglioni-r @AsterITA
IMN-443 - Create new purpose version in purpose-process (#439)
66703f6 
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it>
Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
@renovate-pagopa
Update dependency turbo to v1.13.4 (#605)
2a33b48 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
@renovate-pagopa
Update dependency @types/node to v20.14.1 (#607)
e829b64 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
@renovate-pagopa @ecamellini
Update aws-sdk-js-v3 monorepo to v3.590.0 (#606)
5b27cbb 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
@ecamellini
IMN-600 - Fixing return value for activate agreement (#609)
b39e676
@Carminepo2
Updated build command in purpose-process (#613)
1b799ff
@ecamellini
IMN-601 Fixing contract name creation date (#610)
cbd0996
@ecamellini
IMN-608 - Fixing error in contract creation in case of attribute not …
63a2f1f 
…found (#612)
@renovate-pagopa
Update dependency @types/node to v20.14.2 (#616)
fdbae16 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
@renovate-pagopa
Update dependency @aws-sdk/client-s3 to v3.591.0 (#617)
378d0d7 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
@MalpenZibo
IMN 495 - reduce kafka rebalance log level (#614)
c7e2ab6
@renovate-pagopa @ecamellini
Update dependency pg-promise to v11.8.0 (#618)
814b6f8 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
@Carminepo2
IMN-612 - Added patch client zodios generator in purpose-process (#621)
5f66a72
@MalpenZibo
IMN 589 - Add catalog services return value test (#586)
ad72be5
@ecamellini
Using equality instead of string match for approval policy check (#620)
b4f85a9
@Carminepo2 @taglioni-r @AsterITA
IMN-586 - Risk analysis pdf generation in purpose-process (#593)
58014d1 
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it>
Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
@Carminepo2
Fix Dockerfile in purpose-process (#625)
7023a82
@renovate-pagopa @micdes-pagopa
Update actions/checkout action to v4 (#624)
a865b91 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
@renovate-pagopa
Update aws-sdk-js-v3 monorepo to v3.592.0 (#623)
6cf62eb 
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
@ecamellini ecamellini changed the base branch from main to IMN-745-api-gateway-get-agreement-purposes July 25, 2024 09:33
@ecamellini ecamellini changed the title IMN-763 - API Gateway - GET /purposes IMN-763 + IMN-764 - API Gateway - GET /purposes + GET /purposes/{purposeId} Jul 25, 2024
@ecamellini ecamellini changed the title IMN-763 + IMN-764 - API Gateway - GET /purposes + GET /purposes/{purposeId} IMN-763 + IMN-764 - API Gateway - GET /purposes + GET /purposes/:purposeId Jul 25, 2024
@ecamellini ecamellini mentioned this pull request Jul 25, 2024
Closed
@ecamellini ecamellini marked this pull request as ready for review July 25, 2024 14:05
MalpenZibo
MalpenZibo approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@MalpenZibo MalpenZibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

packages/api-gateway/.env Outdated
@@ -5,6 +5,7 @@ LOG_LEVEL=info
WELL_KNOWN_URLS="https://dev.interop.pagopa.it/.well-known/jwks.json"
ACCEPTED_AUDIENCES="dev.interop.pagopa.it/m2m,refactor.dev.interop.pagopa.it/m2m"

CATALOG_PROCESS_URL="http://localhost:3000"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remember to change this configuration after merging #796

@AsterITA AsterITA force-pushed the IMN-745-api-gateway-get-agreement-purposes branch from fa02a85 to 40ae9c7 Compare July 29, 2024 08:57
@AsterITA AsterITA force-pushed the IMN-763-api-gateway-get-purposes branch from 5d8b795 to 346d8de Compare July 29, 2024 08:57
@ecamellini ecamellini closed this Aug 12, 2024
@ecamellini ecamellini force-pushed the IMN-745-api-gateway-get-agreement-purposes branch from 40ae9c7 to fa02a85 Compare August 12, 2024 08:53
This was referenced Aug 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalpenZibo MalpenZibo MalpenZibo approved these changes

@beetlecrunch beetlecrunch Awaiting requested review from beetlecrunch

@galales galales Awaiting requested review from galales

@AsterITA AsterITA Awaiting requested review from AsterITA

@Carminepo2 Carminepo2 Awaiting requested review from Carminepo2

@taglioni-r taglioni-r Awaiting requested review from taglioni-r

@Viktor-K Viktor-K Awaiting requested review from Viktor-K

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.