IMN-600 - Fixing return value for activate agreement #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
requested review from
Viktor-K,
galales and
MalpenZibo
and removed request for
AsterITA,
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
ecamellini
commented
Jun 5, 2024
| @@ -1176,3 +1190,33 @@ function maybeCreateSetToMissingCertifiedAttributesByPlatformEvent( | |||
| } | |||
| return undefined; | |||
| } | |||
|
|
|||
| // eslint-disable-next-line max-params | |||
| async function addContractOnFirstActivation( | |||
There was a problem hiding this comment.
Moved this here from agreementSubmissionProcessor.ts because now I reuse it also for activation
This was referenced Jun 5, 2024
galales
approved these changes
Jun 5, 2024
| ...agreement.data, | ||
| ...updatedAgreementSeed, | ||
| }; | ||
|
|
||
| const updatedAgreement: Agreement = await addContractOnFirstActivation( | ||
| isFirstActivation, |
There was a problem hiding this comment.
minor personal opinion: it's a but odd that a function receives a flag stating if the function itself will be executed or not.
Probably when refactoring and splitting the two activation functions it will automatically become cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-600
Tests
See automated tests in #567, based on this one.