-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMN-744 - API Gateway - GET /agreements/:agreementId/attributes
#774
Closed
ecamellini
wants to merge
1,118
commits into
IMN-742-api-gateway-get-agreements
from
IMN-744-api-gateway-get-agreement-attributes
Closed
IMN-744 - API Gateway - GET /agreements/:agreementId/attributes
#774
ecamellini
wants to merge
1,118
commits into
IMN-742-api-gateway-get-agreements
from
IMN-744-api-gateway-get-agreement-attributes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com> Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com> Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it>
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it> Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com> Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
ecamellini
force-pushed
the
IMN-742-api-gateway-get-agreements
branch
from
July 25, 2024 08:27
773f08c
to
da9e2b1
Compare
ecamellini
force-pushed
the
IMN-744-api-gateway-get-agreement-attributes
branch
from
July 25, 2024 08:37
7a7f18e
to
12a1fbf
Compare
ecamellini
force-pushed
the
IMN-742-api-gateway-get-agreements
branch
from
July 25, 2024 09:07
f6a8d04
to
dbf1a97
Compare
ecamellini
force-pushed
the
IMN-744-api-gateway-get-agreement-attributes
branch
from
July 25, 2024 09:08
12a1fbf
to
926af8f
Compare
AsterITA
force-pushed
the
IMN-742-api-gateway-get-agreements
branch
from
July 29, 2024 08:57
dbf1a97
to
b0c3e90
Compare
AsterITA
force-pushed
the
IMN-744-api-gateway-get-agreement-attributes
branch
from
July 29, 2024 08:57
926af8f
to
a165b29
Compare
ecamellini
force-pushed
the
IMN-742-api-gateway-get-agreements
branch
from
August 12, 2024 08:50
b0c3e90
to
dbf1a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-744
Based on #764
Tests
Success case 1 - Valid attributes ✅
Agreement & tenant in readmodel
Result:
Success case 2 - Invalid attributes ✅
Making attributes invalid in readmodel tenant
Result
Empty attributes edge case
Errors ❌
Agreement not found
This error "bubbles up" from the agreement process API call response: