Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMN-744 - API Gateway - GET /agreements/:agreementId/attributes #774

Conversation

ecamellini
Copy link
Collaborator

@ecamellini ecamellini commented Jul 22, 2024

Closes IMN-744
Based on #764

Tests

Success case 1 - Valid attributes ✅

Agreement & tenant in readmodel

image image

Result:

image

Success case 2 - Invalid attributes ✅

Making attributes invalid in readmodel tenant

image

Result

image

Empty attributes edge case

image

Errors ❌

Agreement not found

This error "bubbles up" from the agreement process API call response:
image

MalpenZibo and others added 30 commits May 28, 2024 10:37
Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it>
Co-authored-by: Roberto Taglioni <roberto.taglioni@pagopa.it>
Co-authored-by: AsterITA <fabrizio.musella@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
Co-authored-by: Eric Camellini <eric.camellini@gmail.com>
Co-authored-by: renovate-pagopa[bot] <164534245+renovate-pagopa[bot]@users.noreply.github.com>
@ecamellini ecamellini force-pushed the IMN-742-api-gateway-get-agreements branch from 773f08c to da9e2b1 Compare July 25, 2024 08:27
@ecamellini ecamellini force-pushed the IMN-744-api-gateway-get-agreement-attributes branch from 7a7f18e to 12a1fbf Compare July 25, 2024 08:37
@ecamellini ecamellini force-pushed the IMN-742-api-gateway-get-agreements branch from f6a8d04 to dbf1a97 Compare July 25, 2024 09:07
@ecamellini ecamellini force-pushed the IMN-744-api-gateway-get-agreement-attributes branch from 12a1fbf to 926af8f Compare July 25, 2024 09:08
@AsterITA AsterITA force-pushed the IMN-742-api-gateway-get-agreements branch from dbf1a97 to b0c3e90 Compare July 29, 2024 08:57
@AsterITA AsterITA force-pushed the IMN-744-api-gateway-get-agreement-attributes branch from 926af8f to a165b29 Compare July 29, 2024 08:57
@ecamellini ecamellini closed this Aug 12, 2024
@ecamellini ecamellini force-pushed the IMN-742-api-gateway-get-agreements branch from b0c3e90 to dbf1a97 Compare August 12, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.