-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] localize reward gain with hard-coded numBerries(item count) in ME. #4379
[Localization] localize reward gain with hard-coded numBerries(item count) in ME. #4379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WAY better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra spaces are not included in ZH
6328815
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use the {{count}}
interpolation instead (and also pass it in the code).
Why?
The count
interpolation supports the Plurals feature of i18next. So if in the future the text needs to adjust acording to it being 1/2/3 ... items you can achieve that via passing count
.
Check the link for more information.
5111fe6
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
This reverts commit 3ce0805.
src/data/mystery-encounters/encounters/berries-abound-encounter.ts
Outdated
Show resolved
Hide resolved
src/data/mystery-encounters/encounters/berries-abound-encounter.ts
Outdated
Show resolved
Hide resolved
src/data/mystery-encounters/encounters/berries-abound-encounter.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: ImperialSympathizer <110984302+ben-lear@users.noreply.github.com>
What are the changes the user will see?
English : No changes
Some languages : Not to see awkward reward message (with count).
Why am I making these changes?
There's an issue with the script displaying awkwardly when multiple items are obtained during the ME events in some languages (specifically for Korean, Chinese, and Japanese).
It's grammatically correct to use a measure word when referring to items with count.
2 itemName
is grammatically weird in Korean, Chinese, Japanese.In Korean, it should be "2개의 {{itemname}}" or "{{itemname}} 2개"
In Chinese, it should be "2个{{itemname}}" or "{{itemname}}2个"
In Japanese, it should be "2個の{{itemname}}" or "{{itemname}}2個"
What are the changes from a developer perspective?
rewardGainCount
instead ofrewardGain
.Screenshots/Videos
EN
KO
Zh_CN
Zh_TW
JA
How to test the changes?
Manually with overrides.ts
Checklist
beta
as my base branchnpm run test
)