-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] localize reward gain with hard-coded numBerries(item count) in ME. #4379
Open
EnochG1
wants to merge
7
commits into
pagefaultgames:beta
Choose a base branch
from
EnochG1:localization/me-reward-count
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flx-sta
added
Localization
Provides or updates translation efforts
P3 Bug
Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
labels
Sep 23, 2024
returntoice
previously approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WAY better
Chapybara-jp
previously approved these changes
Sep 23, 2024
Adri1
previously approved these changes
Sep 23, 2024
40chyan
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra spaces are not included in ZH
13 tasks
EnochG1
dismissed stale reviews from Adri1, Chapybara-jp, and returntoice
via
September 23, 2024 23:28
6328815
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
Adri1
previously approved these changes
Sep 23, 2024
returntoice
previously approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Localization
Provides or updates translation efforts
P3 Bug
Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
English : No changes
Some languages : Not to see awkward reward message (with count).
Why am I making these changes?
There's an issue with the script displaying awkwardly when multiple items are obtained during the ME events in some languages (specifically for Korean, Chinese, and Japanese).
It's grammatically correct to use a measure word when referring to items with count.
2 itemName
is grammatically weird in Korean, Chinese, Japanese.In Korean, it should be "2개의 {{itemname}}" or "{{itemname}} 2개"
In Chinese, it should be "2个{{itemname}}" or "{{itemname}}2个"
In Japanese, it should be "2個の{{itemname}}" or "{{itemname}}2個"
What are the changes from a developer perspective?
rewardGainCount
instead ofrewardGain
.Screenshots/Videos
EN
KO
Zh_CN
Zh_TW
JA
How to test the changes?
Manually with overrides.ts
Checklist
beta
as my base branchnpm run test
)