Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc][Move] Add waveTurnCount to PokemonBattleData #4168

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Sep 11, 2024

What are the changes the user will see?

Fake Out and First Impression (and Mat Block) can be used at the start of every wave again.

Why am I making these changes?

Slight buff for a couple of moves (requested by @damocleas), and new field in PokemonBattleData that can be used for other things later.

What are the changes from a developer perspective?

waveTurnCount: number = 1 added as a field to PokemonBattleData.
FirstMoveCondition updated to use the new field, allowing moves like Fake Out to be used at the start of every wave even if the Pokémon has been out for multiple turns.

How to test the changes?

npm run test fake_out

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

Swap `FirstMoveCondition` to use the new `waveTurnCount` field
@DayKev DayKev added Move Affects a move Miscellaneous Changes that don't fit under any other label labels Sep 11, 2024
@DayKev DayKev requested a review from a team as a code owner September 11, 2024 15:09
@Tempo-anon
Copy link
Collaborator

To be honest, not a huge fan with a specific hardcoded case just for certain moves and not others. Things should be consistent and not just have kneejerk changes based on vibes, and it seems a lot of complaining about fake out has died off now too.

@damocleas
Copy link
Collaborator

To be honest, not a huge fan with a specific hardcoded case just for certain moves and not others. Things should be consistent and not just have kneejerk changes based on vibes, and it seems a lot of complaining about fake out has died off now too.

you do not see all the feedback I do, there are still consistent complaints and it will feel even worse when we have a real doubles mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants