[Hotfix] Allow Fake Out to be used at the start of every wave again #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damocleas
approved these changes
Sep 8, 2024
|
Please test with mat block too |
|
Mat Block also works. |
Tempo-anon
requested changes
Sep 9, 2024
| @@ -23,6 +23,16 @@ export class BattleEndPhase extends BattlePhase { | |||
| this.scene.unshiftPhase(new GameOverPhase(this.scene, true)); | |||
| } | |||
|
|
|||
| /** | |||
| * Allow Fake Out and First Impression to be used at the start of every wild battle | |||
There was a problem hiding this comment.
If you just want to make a change to two specific moves wouldn't this make more sense as a move attribute rather than doing something that might cause unintended behavior by manually changing a Pokemon's turns out?
|
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Fake Out and First Impression can be used at the start of every wave.
Why am I making these changes?
Request from @damocleas due to player feedback.
What are the changes from a developer perspective?
The active Pokémon's turn count is set to 1 at the start of every wave, so first-turn-only moves won't fail.
How to test the changes?
npm run test fake_outChecklist
[ ] I'm usingbetaas my base branch[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?