[Balance] Ability-ignoring effects no longer ignore the source's own Abilities

[innerthunder]

What are the changes?

This change makes it so that if a Pokemon has an ability or uses a move that ignores ability effects, those ability-ignoring effects do not apply to the user's own abilities. For example, if a Pokemon has Mold Breaker as an ability and Contrary as a passive ability, it using Overheat would now raise the user's Sp. Atk instead of ignoring Contrary and lowering it.

Why am I doing these changes?

This change was requested by the Balance team, fitting in line with previous changes to Neutralizing Gas (#1662 ). Also, this interaction has been reported as a bug before in the Discord, which indicates that players may find this interaction unintuitive as it stands.

What did change?

• field/arena: New field Arena.ignoreAbilitySource tracks the source of active ability-ignoring effects by battler index, and is set within setIgnoreAbilities.
• field/pokemon: Pokemon.canApplyAbility now checks that arena.ignoreAbilitySource does not match the Pokemon's battler index before ignoring abilities' effects.
• phases: Small adjustments reflecting the changes to Arena.setIgnoreAbilities()

Screenshots/Videos

Clanging Scales from a Pokemon with Mold Breaker + Contrary after the changes:

PokeRogue.-.Google.Chrome.2024-08-14.22-03-16.mp4

How to test the changes?

tested via overrides

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[Xavion3]

It's unintuitive partially because Neutralising gas is bugged to not negate abilities like it should which creates an inconsistency, we can easily fix that by just reverting the change which broke it.

Also this is not a quality of life change, this is a significant change in how an ability works with significant balance and gameplay ramifications. This is even a nerf under some circumstances.

The bug report was also thrown off by the text of mold breaker not lining up with the effect, but this change does not solve that problem so that's not really a good excuse either. Unless we want to make it not ignore stuff like lightning rod.

[Xavion3]

As above, this currently fails to actually solve the problem laid out in the reasons for this PR.

[DayKev]

It's unintuitive partially because Neutralising gas is bugged to not negate abilities like it should which creates an inconsistency, we can easily fix that by just reverting the change which broke it.

Also this is not a quality of life change, this is a significant change in how an ability works with significant balance and gameplay ramifications. This is even a nerf under some circumstances.

The bug report was also thrown off by the text of mold breaker not lining up with the effect, but this change does not solve that problem so that's not really a good excuse either. Unless we want to make it not ignore stuff like lightning rod.

So we need balance team comments then.

[innerthunder]

Closing this as there is at least some evidence (via Sunsteel Strike/Moongeist Beam) that ability-ignoring effects apply to the user's ability in mainline; it's just that these effects are never available alongside ignorable abilities (hence Shadow Shield, Full Metal Body, and Mold Breaker itself not being ignorable).

I may reopen this if the Game Design/Balance teams decide custom implementation is needed to remove potential anti-synergy between a Pokemon's passive and ability, but as it stands I'd say the current implementation is more accurate to mainline.

EDIT: nvm I guess lol

AFAIK, this was overruled by the Balance Team. Yes, there's a good chance this diverges from mainline behavior, but it's in the interest of making Mold Breaker more flexible with passive/fusion combos