Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Neutralizing Gas no longer suppresses the source's abilities #1662

Merged
merged 1 commit into from
May 31, 2024

Conversation

innerthunder
Copy link
Collaborator

@innerthunder innerthunder commented May 31, 2024

What are the changes?

A Pokemon with the ability Neutralizing Gas no longer suppresses their passive ability (and vice versa).

Why am I doing these changes?

In its current implementation, Neutralizing Gas suppresses all abilities on the playfield, including the source Pokemon's passive ability (if it has one). However, based on the description for Neutralizing Gas in Gen IX, the source Pokemon's other abilities should not be suppressed.
image

From a balance perspective, this allows Pokemon like Weezing to have a much larger pool of passive abilities to choose from without the fear of them being suppressed. It also facilitates Neutralizing Gas as a passive ability option for Pokemon with valuable primary Abilities that would otherwise be suppressed.

What did change?

  • data/pokemon: Pokemon.canApplyAbility() is changed so that when it checks the Pokemon on the playfield for suppression ability attributes, the check does not include this.

Screenshots/Videos

Video Test:

  • The player's Bulbasaur was given Neutralizing Gas with Intimidate as a passive via src/overrides
  • All enemies were given Intimidate via src/overrides
  • At the start of battle, Bulbasaur's Neutralizing Gas ability is shown, then Bulbasaur's Intimidate activates. The opposing Pidgey's Intimidate is suppressed by Neutralizing Gas and does not activate.
PokeRogue.-.Google.Chrome.2024-05-31.10-50-58.mp4

How to test the changes?

See the use of src/overrides in the test above. You can test with Neutralizing Gas as the passive ability instead, or switch Intimidate with any suppressable ability.

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added the Ability Affects an ability label May 31, 2024
@bennybroseph bennybroseph added the Bug Something isn't working label May 31, 2024
@bennybroseph bennybroseph merged commit 2dff35c into pagefaultgames:main May 31, 2024
2 checks passed
Korwai pushed a commit to Korwai/pokerogue that referenced this pull request Jun 14, 2024
SavGRY pushed a commit to SavGRY/pokerogue that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants