[QoL] Neutralizing Gas no longer suppresses the source's abilities #1662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
A Pokemon with the ability Neutralizing Gas no longer suppresses their passive ability (and vice versa).
Why am I doing these changes?
In its current implementation, Neutralizing Gas suppresses all abilities on the playfield, including the source Pokemon's passive ability (if it has one). However, based on the description for Neutralizing Gas in Gen IX, the source Pokemon's other abilities should not be suppressed.
From a balance perspective, this allows Pokemon like Weezing to have a much larger pool of passive abilities to choose from without the fear of them being suppressed. It also facilitates Neutralizing Gas as a passive ability option for Pokemon with valuable primary Abilities that would otherwise be suppressed.
What did change?
data/pokemon
:Pokemon.canApplyAbility()
is changed so that when it checks the Pokemon on the playfield for suppression ability attributes, the check does not includethis
.Screenshots/Videos
Video Test:
src/overrides
src/overrides
PokeRogue.-.Google.Chrome.2024-05-31.10-50-58.mp4
How to test the changes?
See the use of
src/overrides
in the test above. You can test with Neutralizing Gas as the passive ability instead, or switch Intimidate with any suppressable ability.Checklist
npm run test
)