parallel in crystal alignment #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led (just disable parallel mutlifit for crystal alignment)
cmarooney-stfc
requested changes
Aug 6, 2024
| assertEqualWithSave(obj,fitpar,'tol',1.e-3); | ||
| clear clOb; | ||
|
|
||
| skipTest('Re #1724 This fit fails and should be fixed as part of the ticket #1724') |
There was a problem hiding this comment.
this suggests that the fix is going to be enabling parallel multifit. But the fix in this PR is to disable parallel multifit. At the least this message needs modifying
There was a problem hiding this comment.
parallel multifit is disabled in crystal_alignment. This test shows that parallel multifit fails for a task, similar to crystal_aligmnent but not actually it. You may see that no crystal_alignment is invoked here.
oerc0122
reviewed
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes Re #1721 by disabling parallel multifit in crytal_alignment. It also adds the test, which demonstrates that parallel multifit fails for crytal_alignment case.