Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel multifit fails for some set of input parameters #1724

Open
abuts opened this issue Aug 5, 2024 · 0 comments
Open

Parallel multifit fails for some set of input parameters #1724

abuts opened this issue Aug 5, 2024 · 0 comments
Assignees

Comments

@abuts
Copy link
Member

abuts commented Aug 5, 2024

The ticket Re #1721 fixes crystal_alignment for case when parallel_multifit is enabled by disabling parallel mutlifit option in crystal alignment.

This is probably fine for crystal_alignment as it does not need to run in parallel. But similar issue may occur for different multifit user cases so splitting procedure in multifit should be smarter to identify such parameters and either do correct split or (better) be smart enough to identify that parallel multifit in this case is unnecessary and multifit should not run in parallel.

Unit test written and disabled in Re #1721: Horace\_test\test_multifit_herbert\test_multifit_1.m, row 362 should be fixed.

@abuts abuts changed the title Parallel multifit does not work for crystal alignment Parallel multifit does not work for some set of input parameters Aug 7, 2024
@abuts abuts changed the title Parallel multifit does not work for some set of input parameters Parallel multifit fails for some set of input parameters Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants