Skip to content

Commit

Permalink
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
Browse files Browse the repository at this point in the history
…24792)"

This reverts commit 35541c4.
  • Loading branch information
Your Name committed Oct 1, 2024
1 parent 120729d commit ced869b
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions Lib/test/test_perf_profiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@
raise unittest.SkipTest("test crash randomly on ASAN/MSAN/UBSAN build")


def is_jit_build():
cflags = (sysconfig.get_config_var("PY_CORE_CFLAGS") or '')
return "_Py_JIT" in cflags


if is_jit_build():
raise unittest.SkipTest("Perf support is not available in JIT builds")


def supports_trampoline_profiling():
perf_trampoline = sysconfig.get_config_var("PY_HAVE_PERF_TRAMPOLINE")
if not perf_trampoline:
Expand Down Expand Up @@ -238,7 +229,7 @@ def is_unwinding_reliable_with_frame_pointers():
cflags = sysconfig.get_config_var("PY_CORE_CFLAGS")
if not cflags:
return False
return "no-omit-frame-pointer" in cflags
return "no-omit-frame-pointer" in cflags and "_Py_JIT" not in cflags


def perf_command_works():
Expand Down Expand Up @@ -391,7 +382,6 @@ def baz(n):
self.assertNotIn(f"py::bar:{script}", stdout)
self.assertNotIn(f"py::baz:{script}", stdout)


@unittest.skipUnless(perf_command_works(), "perf command doesn't work")
@unittest.skipUnless(
is_unwinding_reliable_with_frame_pointers(),
Expand Down Expand Up @@ -504,9 +494,7 @@ def _is_perf_version_at_least(major, minor):


@unittest.skipUnless(perf_command_works(), "perf command doesn't work")
@unittest.skipUnless(
_is_perf_version_at_least(6, 6), "perf command may not work due to a perf bug"
)
@unittest.skipUnless(_is_perf_version_at_least(6, 6), "perf command may not work due to a perf bug")
class TestPerfProfilerWithDwarf(unittest.TestCase, TestPerfProfilerMixin):
def run_perf(self, script_dir, script, activate_trampoline=True):
if activate_trampoline:
Expand Down

0 comments on commit ced869b

Please sign in to comment.