-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_perf_profiler fails on Linux (both AArch64 and x86) #124613
Comments
Cc: @pablogsal (as someone who knows a lot about Linux perf) |
The integration has been broken since #123472 (comment) with the stable buildbots failing. Seems that something on that PR broke the buildbot or something changed at that time. |
@pablogsal wrote #124636 to fix the issue. |
It should be fixed by 02b49c5. |
This is still failing on our x86-64 machine
|
The buildbot is green and I cannot reproduce on my x86_64 machine. Are you sure you are using the latest main? If this was working before can you bisect? |
I reopen the issue. Do you mean a 32-bit machine, or do you mean x86-64? |
I meant x86-64, I've edited the comment. |
Buildbot (x86_64) it's currently green as of 8h ago: https://buildbot.python.org/#/builders/1078 |
Cannot reproduce on my aarch64 machines either:
|
With the help of a colleague, we understand where the problem is. On x86-64 and with the JIT enabled, the test needs DWARF unwind information for every frame and the JIT doesn't provide that. On an x86-64 machine and the JIT compiled:
I guess for now we can skip (or xfail) this test if the JIT is enabled and also actually run this test on JIT builds. Tagging @brandtbucher for his information. |
We already have a JIT detection for frame pointer skipping: we just need the same for the other perf mode. I will create a PR :) |
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
* gh-124613: Don't run perf tests in JIT builds Signed-off-by: Pablo Galindo <pablogsal@gmail.com> * Apply suggestions from code review Co-authored-by: Victor Stinner <vstinner@python.org> --------- Signed-off-by: Pablo Galindo <pablogsal@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e44eebf) Co-authored-by: Victor Stinner <vstinner@python.org>
This change skips the test on JIT build. I close again the issue. |
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Bug report
Bug description:
Our CI picked up this failure recently. We are using Ubuntu 24.04 and it is failing both on AArch64 and x86.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
The text was updated successfully, but these errors were encountered: