server: check SHELL if (and only if) neither --sh nor --csh is specified #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous check was checking if the enums returned by getopt were non-zero, which they always are, regardless of whether the option has been specified or not. Fixes: e7d1c91 ("server: Check SHELL only when neither --sh nor --csh is specified") Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check was checking if the enums returned by getopt were non-zero, which they always are, regardless of whether the option has been specified or not.
Fixes: e7d1c91 ("server: Check SHELL only when neither --sh nor --csh is specified") from #438