Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Check SHELL only when neither --sh nor --csh is specified #438

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

ueno
Copy link
Member

@ueno ueno commented Oct 19, 2022

Previously C shell syntax is used for printing environment variable setup even if --sh is given when SHELL is csh.

Reported in:
#437

Fixes: #437
Signed-off-by: Daiki Ueno ueno@gnu.org

@coveralls
Copy link

coveralls commented Oct 19, 2022

Coverage Status

Coverage increased (+0.006%) to 71.342% when pulling f07dcd3 on ueno:wip/dueno/server-csh into 8c917c0 on p11-glue:master.

Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. LGTM

Previously C shell syntax is used for printing environment variable
setup even if --sh is given when SHELL is csh.

Reported in:
p11-glue#437

Signed-off-by: Daiki Ueno <ueno@gnu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment in p11-kit/test-server.sh
3 participants