Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade markdown-link-check #2547

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Conversation

nvuillam
Copy link
Member

No description provided.

@nvuillam
Copy link
Member Author

nvuillam commented Apr 11, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.02s
✅ BASH shellcheck 6 0 0.2s
✅ BASH shfmt 6 0 0 0.42s
✅ COPYPASTE jscpd yes no 3.99s
✅ DOCKERFILE hadolint 116 0 23.68s
✅ JSON eslint-plugin-jsonc 21 0 0 2.96s
✅ JSON jsonlint 19 0 0.3s
✅ JSON v8r 21 0 17.39s
⚠️ MARKDOWN markdownlint 312 0 230 8.8s
✅ MARKDOWN markdown-link-check 312 0 6.87s
✅ MARKDOWN markdown-table-formatter 312 0 0 24.88s
✅ OPENAPI spectral 1 0 2.17s
⚠️ PYTHON bandit 186 54 2.94s
✅ PYTHON black 186 0 0 5.66s
✅ PYTHON flake8 186 0 2.55s
✅ PYTHON isort 186 0 0 1.05s
✅ PYTHON mypy 186 0 10.27s
✅ PYTHON pylint 186 0 16.16s
⚠️ PYTHON pyright 186 251 23.27s
✅ PYTHON ruff 186 0 0 0.48s
✅ REPOSITORY checkov yes no 44.73s
✅ REPOSITORY git_diff yes no 0.39s
✅ REPOSITORY secretlint yes no 17.68s
✅ REPOSITORY trivy yes no 35.91s
✅ SPELL cspell 754 0 32.64s
✅ SPELL misspell 573 0 0 1.07s
✅ XML xmllint 3 0 0 0.43s
✅ YAML prettier 81 0 0 3.79s
✅ YAML v8r 23 0 82.44s
✅ YAML yamllint 82 0 1.51s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Member Author

nvuillam commented Apr 11, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.05s
✅ COPYPASTE jscpd yes no 3.26s
✅ DOCKERFILE hadolint 116 0 16.37s
✅ JSON eslint-plugin-jsonc 21 0 0 1.93s
✅ JSON jsonlint 19 0 0.2s
✅ JSON npm-package-json-lint yes no 0.79s
✅ JSON v8r 21 0 13.36s
⚠️ MARKDOWN markdownlint 312 2 230 6.17s
✅ MARKDOWN markdown-link-check 312 0 5.64s
✅ MARKDOWN markdown-table-formatter 312 2 0 19.79s
✅ OPENAPI spectral 1 0 1.5s
⚠️ PYTHON bandit 186 54 2.45s
✅ PYTHON black 186 0 0 3.78s
✅ PYTHON flake8 186 0 1.96s
✅ PYTHON isort 186 0 0 0.47s
✅ PYTHON mypy 186 0 7.62s
✅ PYTHON pylint 186 0 12.36s
⚠️ PYTHON pyright 186 251 17.33s
✅ PYTHON ruff 186 0 0 0.13s
✅ REPOSITORY checkov yes no 34.45s
⚠️ REPOSITORY devskim yes 61 1.33s
✅ REPOSITORY dustilock yes no 2.58s
✅ REPOSITORY git_diff yes no 0.07s
✅ REPOSITORY secretlint yes no 8.7s
✅ REPOSITORY syft yes no 1.16s
✅ REPOSITORY trivy yes no 23.48s
✅ SPELL cspell 754 0 21.79s
✅ SPELL misspell 573 2 0 0.54s
✅ XML xmllint 3 0 0 0.1s
✅ YAML prettier 81 0 0 2.57s
✅ YAML v8r 23 0 62.76s
✅ YAML yamllint 82 0 1.19s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 4aea9f6 into main Apr 11, 2023
@nvuillam nvuillam deleted the dependencies/markdown-links-check branch April 11, 2023 14:28
@Kurt-von-Laven Kurt-von-Laven changed the title Upgrade markdown-links-check Upgrade markdown-link-check Apr 13, 2023
@Kurt-von-Laven
Copy link
Collaborator

markdown-link-check is still broken at 3.11.1 according to tcort/markdown-link-check#246.

@nvuillam
Copy link
Member Author

@Kurt-von-Laven I read that it's supposed to be fixeD... is it not ? :/

tcort/markdown-link-check#246 (comment)

@Kurt-von-Laven
Copy link
Collaborator

Kurt-von-Laven commented Apr 14, 2023

3.11.0 is broken for everyone with a config file. 3.11.1 is broken for everyone without a config file.

@nvuillam
Copy link
Member Author

So as we provide a default config file, it's ok ? °^^

@Kurt-von-Laven
Copy link
Collaborator

Good point! Yeah, it seems like there are some other less major bugs in 3.11.1, but hopefully enough people will find it preferable to 3.10 overall at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants