Configuration file reading is broken in 3.11.0

[pgrawehr]

After updating to V3.11.0, the -c or --config option no longer works. It is just ignored, and hence any configuration options (like links to ignore) are uneffective.

The tool doesn't even attempt to read the config file. Running

 markdown-link-check.cmd -c .\a-non-existing-file.json -v Documentation\creating-new-release.md

does not produce an error about a missing json file (but only because there's a broken link in that file in my case).

Reverting back to V3.10.3 fixes this.

[laurit]

I think this is caused by updating commander dependency.

markdown-link-check/markdown-link-check

Lines 94 to 98 in 114b966

	input.opts.showProgressBar = (program.progress === true); // force true or undefined to be true or false.
	input.opts.quiet = (program.quiet === true);
	input.opts.verbose = (program.verbose === true);
	input.opts.retryOn429 = (program.retry === true);
	input.opts.aliveStatusCodes = program.alive;

relies on the default behaviour described in https://github.com/tj/commander.js/tree/release/6.x#avoiding-option-name-clashes which seems to have been removed in later versions.

[MarcelMue]

Can only confirm that it's broken and fails silently. cc @tcort if you haven't seen the issue yet ❤️

[belorenz]

Can confirm timeout parameter is ignored in v.3.11.0. Also quiet, which is not part of the config.json.

[maTraxion]

Confirming that ignorePatterns and aliveCodes are currently ignored, haven't validated other configuration as of yet.

[RaimondB]

I can also confirm the issue. Both running via mega-linter, or using the markdown-link-check directly, do not use the igorePatterns as specified in the .markdown-link-check.json. This also does not work when explicitly providing the config file location via the -c option.

This currently break my build, so I will try to use a previous image that does not contain the bug.

[Kurt-von-Laven]

In response to user feedback, I downgraded markdown-link-check to v3.10.3 in MegaLinter v6.22.0. We will unpin markdown-link-check once a fix to this issue is released.

[tcort]

should be fixed in 3.11.1. If not, please re-open.

[nhinze23]

No specified config file now returns an error in 3.11.1

docker run ghcr.io/tcort/markdown-link-check:3.11.1                                         
/src/markdown-link-check:99
		input.opts.config = program.opts().config.trim();
		                                         ^

TypeError: Cannot read properties of undefined (reading 'trim')
    at getInputs (/src/markdown-link-check:99:44)
    at main (/src/markdown-link-check:232:20)

Node.js v19.8.1

[vordimous]

Node.js v19.9.0
/Users/adanelz/Library/pnpm/global/5/.pnpm/markdown-link-check@3.11.1/node_modules/markdown-link-check/markdown-link-check:99
                input.opts.config = program.opts().config.trim();

I am getting this error on the latest version. MacOS install with pnpm.