Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize extends tests #2375

Merged
merged 7 commits into from
Feb 20, 2023
Merged

Organize extends tests #2375

merged 7 commits into from
Feb 20, 2023

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Feb 19, 2023

As I mention in #2371 there is quite a bit of chaos in the organization of test input files:

  • I have organized the test input files by folder.
  • I have created a test that does a mix of local and remote EXTENDS.
  • I improved two asserts to use regular expressions instead of in which does not give so much security.
  • I pass the repository branch by environment variable because right now there are fixed urls against the main branch and if we are testing in a branch, it is not possible to run the tests against the files in your branch.

@nvuillam
Copy link
Member

nvuillam commented Feb 19, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.13s
✅ COPYPASTE jscpd yes no 2.67s
✅ DOCKERFILE hadolint 114 0 15.66s
✅ JSON eslint-plugin-jsonc 21 0 0 2.01s
✅ JSON jsonlint 19 0 0.26s
✅ JSON v8r 21 0 11.44s
⚠️ MARKDOWN markdownlint 309 0 230 5.92s
✅ MARKDOWN markdown-link-check 309 0 5.46s
✅ MARKDOWN markdown-table-formatter 309 0 0 18.32s
✅ OPENAPI spectral 1 0 1.6s
⚠️ PYTHON bandit 183 47 1.99s
✅ PYTHON black 183 1 0 3.58s
✅ PYTHON flake8 183 0 1.76s
✅ PYTHON isort 183 1 0 0.52s
✅ PYTHON mypy 183 0 6.99s
✅ PYTHON pylint 183 0 11.13s
⚠️ PYTHON pyright 183 249 17.04s
✅ REPOSITORY checkov yes no 27.62s
✅ REPOSITORY git_diff yes no 0.12s
✅ REPOSITORY secretlint yes no 14.02s
✅ REPOSITORY trivy yes no 25.74s
✅ SPELL cspell 745 0 18.42s
✅ SPELL misspell 566 0 0 0.59s
✅ XML xmllint 3 0 0 0.17s
✅ YAML prettier 81 2 0 2.54s
✅ YAML v8r 23 0 58.69s
✅ YAML yamllint 82 0 1.02s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)
Will be merged once CI is ok ^^

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 19, 2023

@nvuillam MegaLinter workflow it's failing but I don't understand why, I haven't touched anything related to those files:

https://github.com/oxsecurity/megalinter/actions/runs/4218051705/jobs/7322667444

image

@nvuillam
Copy link
Member

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.03s
✅ BASH shellcheck 6 0 0.3s
✅ BASH shfmt 6 0 0 0.05s
✅ COPYPASTE jscpd yes no 2.85s
✅ DOCKERFILE hadolint 114 0 16.85s
✅ JSON eslint-plugin-jsonc 21 0 0 1.91s
✅ JSON jsonlint 19 0 0.28s
✅ JSON npm-package-json-lint yes no 0.72s
✅ JSON v8r 21 0 12.61s
⚠️ MARKDOWN markdownlint 309 2 230 6.04s
✅ MARKDOWN markdown-link-check 309 0 5.72s
✅ MARKDOWN markdown-table-formatter 309 2 0 17.67s
✅ OPENAPI spectral 1 0 1.82s
⚠️ PYTHON bandit 183 47 4.06s
✅ PYTHON black 183 1 0 3.67s
✅ PYTHON flake8 183 0 1.89s
✅ PYTHON isort 183 1 0 0.49s
✅ PYTHON mypy 183 0 7.75s
✅ PYTHON pylint 183 0 12.23s
⚠️ PYTHON pyright 183 246 19.15s
✅ REPOSITORY checkov yes no 31.63s
⚠️ REPOSITORY devskim yes 61 1.41s
✅ REPOSITORY dustilock yes no 1.48s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 9.42s
✅ REPOSITORY syft yes no 1.18s
✅ REPOSITORY trivy yes no 24.45s
✅ SPELL cspell 745 0 19.41s
✅ SPELL misspell 566 2 0 0.64s
✅ XML xmllint 3 0 0 0.03s
✅ YAML prettier 81 0 0 2.72s
✅ YAML v8r 23 0 58.15s
✅ YAML yamllint 82 0 1.2s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit e90b345 into main Feb 20, 2023
@nvuillam nvuillam deleted the features/organize-extends-tests branch February 20, 2023 04:45
@nvuillam
Copy link
Member

Probably something about future conflicts... i merged, we'll see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants