-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't Extend A Remote Config That Extends A Local Config #2371
Comments
Are you going to work on it? I see that you are quite clear about the implementation. However, you should keep in mind that it should not break what already works, ie:
In the meantime I am going to create a PR to organize the existing input files for these tests that may help you as there is a bit of chaos right now. |
Thank you for cleaning up the tests! Yeah, the ability to pass an array of objects to |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
Describe the bug
When you extend a config in a different repository that extends a config within said repository, the keys from the parent config are properly incorporated, but the grandparent config is completely ignored.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected the inheritance to apply recursively.
Additional context
There were recent fixes for extending local files and extending recursively, but the case where both features are combined isn't handled properly. Renovate has sophisticated support for config inheritance, which may be a helpful reference. One solution might be to specify the base (e.g., repo) URL in one config key and the path relative to the base URL in another.
The text was updated successfully, but these errors were encountered: