Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): catch more cases in const-comparisons #8215

Merged

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jan 1, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review January 1, 2025 20:56
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jan 1, 2025
Copy link
Contributor Author

camc314 commented Jan 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/01-01-feat_linter_catch_more_cases_in_const-comparisons branch from dee016f to a3440dd Compare January 1, 2025 21:00
Copy link

codspeed-hq bot commented Jan 1, 2025

CodSpeed Performance Report

Merging #8215 will not alter performance

Comparing c/01-01-feat_linter_catch_more_cases_in_const-comparisons (7367d28) with main (05be1fc)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 force-pushed the c/01-01-feat_linter_catch_more_cases_in_const-comparisons branch 2 times, most recently from 123cbfe to 8358931 Compare January 1, 2025 21:46
@camc314 camc314 force-pushed the c/01-01-feat_linter_catch_more_cases_in_const-comparisons branch from 8358931 to 7367d28 Compare January 1, 2025 21:53
@Boshen Boshen merged commit 0e168b8 into main Jan 2, 2025
27 checks passed
@Boshen Boshen deleted the c/01-01-feat_linter_catch_more_cases_in_const-comparisons branch January 2, 2025 10:32
@oxc-bot oxc-bot mentioned this pull request Jan 2, 2025
Boshen added a commit that referenced this pull request Jan 2, 2025
## [0.15.5] - 2025-01-02

### Features

- 0e168b8 linter: Catch more cases in const-comparisons (#8215)
(Cameron)
- bde44a3 linter: Add `statement_span` to `ModuleRecord/ImportEntry`
(#8195) (Alexander S.)
- ccaa9f7 linter: Implement `eslint/new-cap`  (#8146) (Alexander S.)

### Bug Fixes

- 2b14a6f linter: Fix `ignorePattern` config for windows (#8214)
(Alexander S.)

### Testing

- cb709c9 linter: Fix some oxlint tests on windows (#8204) (Cameron)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants