fix(linter): fix ignorePattern config for windows
#8214
Merged
+42
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Sysix
changed the title
ignorePattern config for windows
…tern-under-windows
Sysix
changed the title
ignorePattern config for windows ignorePattern config for windows
Sysix
force-pushed
the
fix-linter-ignore-pattern-under-windows
branch
from
4d8bbbf to
02cb4dc
Compare
CodSpeed Performance ReportMerging #8214 will not alter performanceComparing Summary
|
Sysix
force-pushed
the
fix-linter-ignore-pattern-under-windows
branch
from
d6a8af1 to
72ad584
Compare
camc314
approved these changes
Jan 1, 2025
Boshen
added a commit
that referenced
this pull request
Jan 2, 2025
## [0.15.5] - 2025-01-02 ### Features - 0e168b8 linter: Catch more cases in const-comparisons (#8215) (Cameron) - bde44a3 linter: Add `statement_span` to `ModuleRecord/ImportEntry` (#8195) (Alexander S.) - ccaa9f7 linter: Implement `eslint/new-cap` (#8146) (Alexander S.) ### Bug Fixes - 2b14a6f linter: Fix `ignorePattern` config for windows (#8214) (Alexander S.) ### Testing - cb709c9 linter: Fix some oxlint tests on windows (#8204) (Cameron) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ignorePatternsnot asPath, because the createignoredoes only handle/and not Win-style\canonicalizebecause it prefix the paths with\\?\,read more here: https://stackoverflow.com/a/41233992/7387397
closes #8188