Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks/lint_rules): fix regex for syncing vitest rules #7890

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Dec 14, 2024

output:

~/dev/oxc$ node tasks/lint_rules/ --target vitest
👀 promise/spec-only is implemented but not found in their rules
👀 unicorn/consistent-existence-index-check is implemented but not found in their rules
👀 unicorn/prefer-math-min-max is implemented but not found in their rules

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is tracking issue for eslint-plugin-vitest.

There are 51(+ 1 deprecated) rules.

  • 1/8 recommended rules are remaining as TODO
  • 30/43 not recommended rules are remaining as TODO

To get started, run the following command:

just new-vitest-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✨: 7, 🚫: 0 / total: 8
Status Name Docs
vitest/no-identical-title https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-identical-title.md
vitest/expect-expect https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/expect-expect.md
vitest/no-commented-out-tests https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-commented-out-tests.md
vitest/no-import-node-test https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-import-node-test.md
vitest/valid-title https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/valid-title.md
vitest/valid-expect https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/valid-expect.md
vitest/require-local-test-context-for-concurrent-snapshots https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/require-local-test-context-for-concurrent-snapshots.md
vitest/valid-describe-callback https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/valid-describe-callback.md

✨ = Implemented, 🚫 = No need to implement

Not recommended rules

✨: 13, 🚫: 0 / total: 43
Status Name Docs
vitest/prefer-lowercase-title https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-lowercase-title.md
vitest/max-nested-describe https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/max-nested-describe.md
vitest/no-focused-tests https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-focused-tests.md
vitest/no-conditional-tests https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-tests.md
vitest/consistent-test-it https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/consistent-test-it.md
vitest/prefer-to-be https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-be.md
vitest/no-hooks https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-hooks.md
vitest/no-restricted-vi-methods https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-restricted-vi-methods.md
vitest/consistent-test-filename https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/consistent-test-filename.md
vitest/max-expects https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/max-expects.md
vitest/no-alias-methods https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-alias-methods.md
vitest/no-conditional-expect https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-expect.md
vitest/no-conditional-in-test https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-in-test.md
vitest/no-disabled-tests https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-disabled-tests.md
vitest/no-duplicate-hooks https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-duplicate-hooks.md
vitest/no-large-snapshots https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-large-snapshots.md
vitest/no-interpolation-in-snapshots https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-interpolation-in-snapshots.md
vitest/no-mocks-import https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-mocks-import.md
vitest/no-restricted-matchers https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-restricted-matchers.md
vitest/no-standalone-expect https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-standalone-expect.md
vitest/no-test-prefixes https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-test-prefixes.md
vitest/no-test-return-statement https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-test-return-statement.md
vitest/prefer-called-with https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-with.md
vitest/prefer-to-be-falsy https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-be-falsy.md
vitest/prefer-to-be-object https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-be-object.md
vitest/prefer-to-be-truthy https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-be-truthy.md
vitest/prefer-to-have-length https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-have-length.md
vitest/prefer-equality-matcher https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-equality-matcher.md
vitest/prefer-strict-equal https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-strict-equal.md
vitest/prefer-expect-resolves https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-expect-resolves.md
vitest/prefer-each https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-each.md
vitest/prefer-hooks-on-top https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-hooks-on-top.md
vitest/prefer-hooks-in-order https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-hooks-in-order.md
vitest/prefer-mock-promise-shorthand https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-mock-promise-shorthand.md
vitest/prefer-snapshot-hint https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-snapshot-hint.md
vitest/require-top-level-describe https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/require-top-level-describe.md
vitest/require-to-throw-message https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/require-to-throw-message.md
vitest/require-hook https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/require-hook.md
vitest/prefer-todo https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-todo.md
vitest/prefer-spy-on https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-spy-on.md
vitest/prefer-comparison-matcher https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-comparison-matcher.md
vitest/prefer-to-contain https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-to-contain.md
vitest/prefer-expect-assertions https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-expect-assertions.md

✨ = Implemented, 🚫 = No need to implement

Deprecated rules

✨: 0, 🚫: 0 / total: 1
Status Name Docs
vitest/no-done-callback https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/no-done-callback.md

✨ = Implemented, 🚫 = No need to implement

Copy link

graphite-app bot commented Dec 14, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-bug Category - Bug label Dec 14, 2024
Boshen pushed a commit that referenced this pull request Dec 14, 2024
…7891)

based on #7890

tried graphite, but I do not have write access to this repo.  
Do not know how to create Branches on a Fork and the PRs on the Forked
Project.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Boshen
Copy link
Member

Boshen commented Dec 14, 2024

Graphite requires write access to the repo :-/

@Sysix
Copy link
Collaborator Author

Sysix commented Dec 14, 2024

Graphite requires write access to the repo :-/

I am fine with it. Just wondered because I got mail from them :)

Closing because the Stack is merged

@Sysix Sysix closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants