Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add the no_identical_title rule for vitest #7889

Closed

Conversation

Spoutnik97
Copy link
Contributor

Thanks to Wenzhe Wang for the original code for jest

Copy link

graphite-app bot commented Dec 14, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 14, 2024
Copy link

codspeed-hq bot commented Dec 14, 2024

CodSpeed Performance Report

Merging #7889 will not alter performance

Comparing Spoutnik97:linter/no-identical-title (429605f) with main (3858221)

Summary

✅ 29 untouched benchmarks

@Sysix
Copy link
Collaborator

Sysix commented Dec 14, 2024

This should be already covered by jest/no_identical_title.rs and the remapping here:
https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/utils/mod.rs#L20

The doc gh issue is out of sync and will be fixed in #7890

Thanks to Wenzhe Wang for the original code for jest
@Spoutnik97 Spoutnik97 force-pushed the linter/no-identical-title branch from d464b95 to 429605f Compare December 14, 2024 15:33
@camc314
Copy link
Contributor

camc314 commented Dec 14, 2024

given @Sysix 's comment, i think we can close this?

@camc314 camc314 closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants