Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter/only-used-in-recursion): improve implementation to remove using SymbolFlags::Export #7413

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 22, 2024

part of #7414

Copy link

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 22, 2024
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #7413 will not alter performance

Comparing 11-22-refactor_linter_only-used-in-recursion_improve_implementation_to_remove_using_symbolflags_export (c90537f) with main (7ff9f13)

Summary

✅ 30 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 22, 2024
Copy link

graphite-app bot commented Nov 22, 2024

Merge activity

@Boshen Boshen force-pushed the 11-22-refactor_linter_no-unused-vars_improve_implementation_to_remove_using_symbolflags_export branch from e0e6329 to c8adc46 Compare November 22, 2024 09:17
@Boshen Boshen force-pushed the 11-22-refactor_linter_only-used-in-recursion_improve_implementation_to_remove_using_symbolflags_export branch from 32228c2 to c90537f Compare November 22, 2024 09:18
Base automatically changed from 11-22-refactor_linter_no-unused-vars_improve_implementation_to_remove_using_symbolflags_export to main November 22, 2024 09:23
@graphite-app graphite-app bot merged commit c90537f into main Nov 22, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 11-22-refactor_linter_only-used-in-recursion_improve_implementation_to_remove_using_symbolflags_export branch November 22, 2024 09:27
Boshen added a commit that referenced this pull request Nov 23, 2024
## [0.13.1] - 2024-11-23

### Features

- 4ad26b9 linter: Add `no-promise-in-callback` (#7307) (no-yan)
- 9558087 oxlint: Auto detect config file in CLI (#7348) (Alexander S.)

### Bug Fixes

- 8507464 linter: Hanging when source has syntax/is flow (#7432)
(Cameron)
- e88cf1b linter: Make `overrides` globs relative to config path (#7407)
(camchenry)
- 9002e97 linter: Add proper support for findIndex and findLastIndex for
`unicorn/prefer-array-some` (#7405) (Dmitry Zakharov)

### Documentation

- 6730e3e linter: Add more examples for `unicorn/prefer-array-some`
(#7411) (Dmitry Zakharov)

### Refactor

- 6c0d31b linter: Remove useless `const` declaration (#7430) (Song Gao)
- c8adc46 linter/no-unused-vars: Improve implementation to remove using
SymbolFlags::Export (#7412) (Dunqing)
- c90537f linter/only-used-in-recursion: Improve implementation to
remove using SymbolFlags::Export (#7413) (Dunqing)

### Testing

- 779f479 editor: Check if workspace configuration is updated (#7403)
(Alexander S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant