feat(linter): add no-promise-in-callback
#7307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #7307 will not alter performanceComparing Summary
|
no-yan
commented
Nov 16, 2024
camc314
approved these changes
Nov 21, 2024
Boshen
added a commit
that referenced
this pull request
Nov 23, 2024
## [0.13.1] - 2024-11-23 ### Features - 4ad26b9 linter: Add `no-promise-in-callback` (#7307) (no-yan) - 9558087 oxlint: Auto detect config file in CLI (#7348) (Alexander S.) ### Bug Fixes - 8507464 linter: Hanging when source has syntax/is flow (#7432) (Cameron) - e88cf1b linter: Make `overrides` globs relative to config path (#7407) (camchenry) - 9002e97 linter: Add proper support for findIndex and findLastIndex for `unicorn/prefer-array-some` (#7405) (Dmitry Zakharov) ### Documentation - 6730e3e linter: Add more examples for `unicorn/prefer-array-some` (#7411) (Dmitry Zakharov) ### Refactor - 6c0d31b linter: Remove useless `const` declaration (#7430) (Song Gao) - c8adc46 linter/no-unused-vars: Improve implementation to remove using SymbolFlags::Export (#7412) (Dunqing) - c90537f linter/only-used-in-recursion: Improve implementation to remove using SymbolFlags::Export (#7413) (Dunqing) ### Testing - 779f479 editor: Check if workspace configuration is updated (#7403) (Alexander S.) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #4655
This PR implements a rule to detect Promises inside error-first callbacks, preventing the mixed usage of callbacks and Promises.
Example of problematic code:
Original implementation