Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 5, 2025

All Address's methods are a single instruction, or complete no-ops. Compiler should inline them, but make sure by marking them all #[inline(always)].

Copy link
Member Author

overlookmotel commented Nov 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 5, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 5, 2025 12:46
@overlookmotel overlookmotel self-assigned this Nov 5, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025

CodSpeed Performance Report

Merging #15324 will not alter performance

Comparing 11-05-perf_allocator_inline_always_all_address_methods (6b04454) with 11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_ (ef4de9f)

Summary

✅ 37 untouched

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
Copy link
Member Author

overlookmotel commented Nov 5, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_ branch from 644da49 to bec140b Compare November 5, 2025 13:47
graphite-app bot pushed a commit that referenced this pull request Nov 5, 2025
All `Address`'s methods are a single instruction, or complete no-ops. Compiler should inline them, but make sure by marking them all `#[inline(always)]`.
@graphite-app graphite-app bot force-pushed the 11-05-perf_allocator_inline_always_all_address_methods branch from 2d5517e to bb0792a Compare November 5, 2025 13:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
overlookmotel added a commit that referenced this pull request Nov 5, 2025
All `Address`'s methods are a single instruction, or complete no-ops. Compiler should inline them, but make sure by marking them all `#[inline(always)]`.
@overlookmotel overlookmotel force-pushed the 11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_ branch from bec140b to 9d7b273 Compare November 5, 2025 14:54
@overlookmotel overlookmotel force-pushed the 11-05-perf_allocator_inline_always_all_address_methods branch from bb0792a to a2d6fbf Compare November 5, 2025 14:54
overlookmotel added a commit that referenced this pull request Nov 5, 2025
All `Address`'s methods are a single instruction, or complete no-ops. Compiler should inline them, but make sure by marking them all `#[inline(always)]`.
@overlookmotel overlookmotel force-pushed the 11-05-perf_allocator_inline_always_all_address_methods branch from a2d6fbf to 6b04454 Compare November 5, 2025 15:26
@overlookmotel overlookmotel force-pushed the 11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_ branch from 9d7b273 to ef4de9f Compare November 5, 2025 15:26
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
All `Address`'s methods are a single instruction, or complete no-ops. Compiler should inline them, but make sure by marking them all `#[inline(always)]`.
@graphite-app graphite-app bot force-pushed the 11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_ branch from ef4de9f to 55b533c Compare November 5, 2025 15:42
@graphite-app graphite-app bot force-pushed the 11-05-perf_allocator_inline_always_all_address_methods branch from 6b04454 to b5d6360 Compare November 5, 2025 15:42
Base automatically changed from 11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_ to main November 5, 2025 15:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
@graphite-app graphite-app bot merged commit b5d6360 into main Nov 5, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-05-perf_allocator_inline_always_all_address_methods branch November 5, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants