fix(allocator): avoid dereferencing Box when obtaining its Address
#15322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #15322 will improve performances by 3.83%Comparing Summary
Benchmarks breakdown
|
overlookmotel
force-pushed
the
11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_
branch
from
a1a0c49 to
644da49
Compare
overlookmotel
force-pushed
the
11-05-feat_allocator_add_box_as_non_null_method
branch
from
d806f3c to
f42e703
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
11-05-feat_allocator_add_box_as_non_null_method
branch
from
f42e703 to
1274291
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
#15322) Use `Box::as_non_null` method (added in #15321) to ensure that creating an `Address` from a `Box`, no intermediate reference to the contents of the `Box` is created. This is important in `Traverse` which has tight aliasing constraints. Possibly `addr_of!` macro we used previously already ensured this, but I'm not 100% sure due to the double deref (`**`). Using `Box::as_non_null` is unambiguously safe.
graphite-app
bot
force-pushed
the
11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_
branch
from
644da49 to
bec140b
Compare
overlookmotel
force-pushed
the
11-05-feat_allocator_add_box_as_non_null_method
branch
from
1274291 to
f93b292
Compare
overlookmotel
force-pushed
the
11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_
branch
2 times, most recently
from
9d7b273 to
ef4de9f
Compare
overlookmotel
force-pushed
the
11-05-feat_allocator_add_box_as_non_null_method
branch
from
f93b292 to
4114c3b
Compare
Member
Author
|
The benchmark results (+3% on minifier[cal.com.tsx]) are erroneous. Just noise. |
#15322) Use `Box::as_non_null` method (added in #15321) to ensure that creating an `Address` from a `Box`, no intermediate reference to the contents of the `Box` is created. This is important in `Traverse` which has tight aliasing constraints. Possibly `addr_of!` macro we used previously already ensured this, but I'm not 100% sure due to the double deref (`**`). Using `Box::as_non_null` is unambiguously safe.
graphite-app
bot
force-pushed
the
11-05-feat_allocator_add_box_as_non_null_method
branch
from
4114c3b to
b401708
Compare
graphite-app
bot
force-pushed
the
11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_
branch
from
ef4de9f to
55b533c
Compare
Base automatically changed from
11-05-feat_allocator_add_box_as_non_null_method
to
main
November 5, 2025 15:47
graphite-app
bot
deleted the
11-05-fix_allocator_avoid_dereferencing_box_when_obtaining_its_address_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Box::as_non_nullmethod (added in #15321) to ensure that creating anAddressfrom aBox, no intermediate reference to the contents of theBoxis created. This is important inTraversewhich has tight aliasing constraints.Possibly
addr_of!macro we used previously already ensured this, but I'm not 100% sure due to the double deref (**). UsingBox::as_non_nullis unambiguously safe.