Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 15, 2025

Pure refactor. Shorten the raw transfer code for Comment, removing an unnecessary temp var. This also prepares the way for #14624, working around a bug in the codegen where preamble can get inserted after code that uses vars defined in that preamble.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-ast Area - AST labels Oct 15, 2025
Copy link
Member Author

overlookmotel commented Oct 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 15, 2025
@overlookmotel overlookmotel marked this pull request as ready for review October 15, 2025 12:17
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #14623 will not alter performance

Comparing 10-15-refactor_napi_parser_shorten_raw_transfer_deserializer_for_comment_ (2b14abc) with main (48e3348)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (77c4aa0) during the generation of this report, so 48e3348 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel self-assigned this Oct 15, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 15, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2025

Merge activity

#14623)

Pure refactor. Shorten the raw transfer code for `Comment`, removing an unnecessary temp var. This also prepares the way for #14624, working around a bug in the codegen where preamble can get inserted after code that uses vars defined in that preamble.
@graphite-app graphite-app bot force-pushed the 10-15-feat_ast_tools_add_estree_no_parent_attribute branch from 5c02ca9 to 77c4aa0 Compare October 15, 2025 12:21
@graphite-app graphite-app bot force-pushed the 10-15-refactor_napi_parser_shorten_raw_transfer_deserializer_for_comment_ branch from a851140 to 2b14abc Compare October 15, 2025 12:22
Base automatically changed from 10-15-feat_ast_tools_add_estree_no_parent_attribute to main October 15, 2025 12:27
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 15, 2025
@graphite-app graphite-app bot merged commit 2b14abc into main Oct 15, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-15-refactor_napi_parser_shorten_raw_transfer_deserializer_for_comment_ branch October 15, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-cli Area - CLI A-linter Area - Linter A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants