Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 15, 2025

Add support for #[estree(no_parent)] attribute, which tells raw transfer codegen not to add parent field to a struct. We use this in #14624 to remove parent field from Comment.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Oct 15, 2025
Copy link
Member Author

overlookmotel commented Oct 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 15, 2025
@overlookmotel overlookmotel marked this pull request as ready for review October 15, 2025 12:15
@overlookmotel overlookmotel requested review from Copilot and removed request for Copilot October 15, 2025 12:15
@overlookmotel overlookmotel self-assigned this Oct 15, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 15, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2025

Merge activity

Add support for `#[estree(no_parent)]` attribute, which tells raw transfer codegen not to add `parent` field to a struct. We use this in #14624 to remove `parent` field from `Comment`.
@graphite-app graphite-app bot force-pushed the 10-15-feat_ast_tools_add_estree_no_parent_attribute branch from 5c02ca9 to 77c4aa0 Compare October 15, 2025 12:21
graphite-app bot pushed a commit that referenced this pull request Oct 15, 2025
Part of #14564.

#14589 added first part of support for comments-related APIs in Oxlint JS plugins, but `Comment` objects had an extraneous `parent` field. This PR removes that field, using the `#[estree(no_parent)]` attribute (added in #14622).
@graphite-app graphite-app bot merged commit 77c4aa0 into main Oct 15, 2025
18 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 15, 2025
@graphite-app graphite-app bot deleted the 10-15-feat_ast_tools_add_estree_no_parent_attribute branch October 15, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants