fix(oxlint): ignore fixtures dir for vitest #14414

camc314 · 2025-10-07T15:32:27Z

not sure why, but I was getting this error:

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 4 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  fixtures/overrides_with_plugin/index.test.ts [ fixtures/overrides_with_plugin/index.test.ts ]
ReferenceError: describe is not defined
 ❯ fixtures/overrides_with_plugin/index.test.ts:1:1
      1| describe("", () => {
       | ^
      2|   // ^ jest/no-valid-title error as explicitly set in the `.test.ts` override
      3| 

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/4]⎯

 FAIL  fixtures/eslintrc_vitest_replace/foo.test.js [ fixtures/eslintrc_vitest_replace/foo.test.js ]
ReferenceError: test is not defined
 ❯ fixtures/eslintrc_vitest_replace/foo.test.js:1:1
      1| test.skip('foo', () => {
       | ^
      2|   // ...
      3| })

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/4]⎯

 FAIL  fixtures/issue_10394/foo.test.ts [ fixtures/issue_10394/foo.test.ts ]
ReferenceError: describe is not defined
 ❯ fixtures/issue_10394/foo.test.ts:1:1
      1| describe("", () => {
       | ^
      2|   //
      3| });

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[3/4]⎯

 FAIL  fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js [ fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js ]
Error: No test suite found in file /Users/cameron/github/Boshen/oxc/apps/oxlint/fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[4/4]⎯


 Test Files  4 failed | 3 passed (7)
      Tests  61 passed (61)
   Start at  16:31:02
   Duration  2.88s

camc314 · 2025-10-07T15:32:43Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

Exclude Vitest from running fixture tests in apps/oxlint to prevent unintended execution of example/fixture files that are not real test suites.

Add test.exclude to Vitest config to skip the fixtures directory
Keep config minimal within apps/oxlint

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

apps/oxlint/vitest.config.ts

overlookmotel

Makes sense. fixtures dir contains.test.ts files, so you'd expect Vitest to find them and try to run them.

pnpm test translates to vitest --dir ./test run, so it skips the fixtures dir. But pnpm vitest wouldn't.

camc314 · 2025-10-07T16:33:05Z

Merge activity

Oct 7, 4:33 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 7, 4:33 PM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 7, 4:38 PM UTC: Merged by the Graphite merge queue.

not sure why, but I was getting this error: ``` ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 4 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ FAIL fixtures/overrides_with_plugin/index.test.ts [ fixtures/overrides_with_plugin/index.test.ts ] ReferenceError: describe is not defined ❯ fixtures/overrides_with_plugin/index.test.ts:1:1 1| describe("", () => { | ^ 2| // ^ jest/no-valid-title error as explicitly set in the `.test.ts` override 3| ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/4]⎯ FAIL fixtures/eslintrc_vitest_replace/foo.test.js [ fixtures/eslintrc_vitest_replace/foo.test.js ] ReferenceError: test is not defined ❯ fixtures/eslintrc_vitest_replace/foo.test.js:1:1 1| test.skip('foo', () => { | ^ 2| // ... 3| }) ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/4]⎯ FAIL fixtures/issue_10394/foo.test.ts [ fixtures/issue_10394/foo.test.ts ] ReferenceError: describe is not defined ❯ fixtures/issue_10394/foo.test.ts:1:1 1| describe("", () => { | ^ 2| // 3| }); ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[3/4]⎯ FAIL fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js [ fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js ] Error: No test suite found in file /Users/cameron/github/Boshen/oxc/apps/oxlint/fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[4/4]⎯ Test Files 4 failed | 3 passed (7) Tests 61 passed (61) Start at 16:31:02 Duration 2.88s ```

## [1.21.0] - 2025-10-08 ### 🚀 Features - 576be20 linter/plugins: Support selectors DSL (#14435) (overlookmotel) - b2de44f linter/plugins: Support interpolation in normal diagnostic `message` (#14419) (overlookmotel) - 382c5be linter/plugins: Support placeholders in messageIds (#14416) (camc314) - 529e88e linter/plugins: Support `messageId`s (#14415) (camc314) - 83e7824 linter: Add `vue/require-default-export` rule (#14351) (Sysix) - ff98536 linter: Add `vue/no-import-compiler-macros` rule (#14335) (Sysix) - 0ec0847 ci: Run napi tests on windows (#14383) (camc314) ### 🐛 Bug Fixes - 11e0440 linter/jsx-handler-name: Improve handler name position in error messages (#14174) (Takuji Shimokawa) - 493082c language_server: Use the first Span of the message as the primary Diagnostic range (#14057) (Sysix) - 88ec1bd linter/plugins: Fix error messages (#14423) (overlookmotel) - 18616c2 oxlint: Ignore fixtures dir for vitest (#14414) (camc314) - ec02fe8 oxlint: Normalize path separators in snapshot tests (#14406) (camc314) - 6e8d2f6 language_server: Ignore JS plugins (#14379) (overlookmotel) - 96663fb linter/plugins: Do not call `before` hook if empty visitor (#14401) (overlookmotel) - 52f04bd linter: Use `pathToFileURL` for importing plugins to ensure correct URL format (#14394) (camc314) - 1ea0d46 oxlint: Resolve tsdown deprecation warning (#14389) (camc314) - bb679b5 linter: Promise/prefer-await-to-then strict option not reading from config (#14382) (camc314) ### 🚜 Refactor - 3374b8e linter/language_server: Move all lsp relevant code to `oxc_language_server` crate (#14430) (Sysix) - d24b74e linter/language_server: `oxc_linter::TsgoLinter::run_source` returns `Message` (#14429) (Sysix) - e5b7fb2 linter/language_server: `oxc_linter::Runtime::run_source` returns `Message` (#14428) (Sysix) - 3b26bf3 linter/plugins: Split adding visit function to compiler visitor into multiple functions (#14433) (overlookmotel) - af3a75e linter/plugins: Track ancestors while walking AST (#14432) (overlookmotel) - f279f0b linter/plugins: Do not lazy-load visitor keys (#14431) (overlookmotel) - 5e99ed3 linter/plugins: Allow nullish values as `message` or `messageId` (#14422) (overlookmotel) - dc30938 linter/plugins: Remove default value from `Context` constructor (#14421) (overlookmotel) - 28cfae0 oxlint: Use `vitest`s built in file snapshot comparison (#14392) (camc314) - 06b0e9f linter/plugins: Convert generated files to TS (#14385) (overlookmotel) - 52f35c6 napi/parser, linter/plugins: Rename `types.js` to `type_ids.js` (#14384) (overlookmotel) ### ⚡ Performance - 26435a1 linter/plugins: Small perf optimizations (#14420) (overlookmotel) - d8a8be1 linter/plugins: Avoid private methods (#14418) (overlookmotel) ### 🧪 Testing - d8da4a4 linter/plugins: Clarify tests for message placeholders (#14417) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Oct 7, 2025

camc314 marked this pull request as ready for review October 7, 2025 15:32

Copilot AI review requested due to automatic review settings October 7, 2025 15:32

Copilot AI reviewed Oct 7, 2025

View reviewed changes

apps/oxlint/vitest.config.ts Outdated Show resolved Hide resolved

camc314 force-pushed the c/10-07-fix_oxlint_ignore_fixtures_dir_for_vitest branch from c8f57c5 to ba33e2b Compare October 7, 2025 15:51

camc314 assigned overlookmotel Oct 7, 2025

This was referenced Oct 7, 2025

feat(linter/plugins): support messageIds #14415

Merged

feat(linter/plugins): support placeholders in messageIds #14416

Merged

overlookmotel approved these changes Oct 7, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025

graphite-app bot force-pushed the c/10-07-fix_oxlint_ignore_fixtures_dir_for_vitest branch from ba33e2b to 18616c2 Compare October 7, 2025 16:33

graphite-app bot merged commit 18616c2 into main Oct 7, 2025
18 checks passed

graphite-app bot deleted the c/10-07-fix_oxlint_ignore_fixtures_dir_for_vitest branch October 7, 2025 16:38

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 7, 2025

This was referenced Oct 8, 2025

release(oxlint): v1.21.0 #14439

Closed

release(oxlint): v1.21.0 #14441

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(oxlint): ignore fixtures dir for vitest #14414

fix(oxlint): ignore fixtures dir for vitest #14414

Uh oh!

camc314 commented Oct 7, 2025 •

edited

Loading

Uh oh!

camc314 commented Oct 7, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

overlookmotel left a comment

Uh oh!

camc314 commented Oct 7, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(oxlint): ignore fixtures dir for vitest #14414

fix(oxlint): ignore fixtures dir for vitest #14414

Uh oh!

Conversation

camc314 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 commented Oct 7, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Oct 7, 2025 •

edited

Loading

camc314 commented Oct 7, 2025 •

edited

Loading

camc314 commented Oct 7, 2025 •

edited by graphite-app bot

Loading