fix(linter/jsx-handler-name): improve handler name position in error messages #14174

takuji · 2025-09-27T04:10:03Z

With this change, when an event handler name is detected, the underline in the error message will point only to the event handler name.

graphite-app · 2025-09-27T04:10:12Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Copilot

Pull Request Overview

This PR improves the error message positioning for the jsx-handler-names linter rule by making the underline point specifically to the event handler name rather than the entire expression. The change enhances the precision of error reporting by extracting and highlighting only the relevant handler name portion.

Key changes:

Refactored handler name extraction logic to return both the name and its specific span
Modified error diagnostic to use the precise handler name span instead of the entire expression container span
Added support for detecting "props" handlers to allow proper validation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_linter/src/rules/react/jsx_handler_names.rs	Refactored handler name extraction with precise span tracking and added props handler detection
crates/oxc_linter/src/snapshots/react_jsx_handler_names.snap	Updated test snapshots showing improved error message positioning

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/react/jsx_handler_names.rs

codspeed-hq · 2025-09-27T04:15:25Z

CodSpeed Performance Report

Merging #14174 will not alter performance

_{Comparing takuji:jsx-handler-names-improve-handler-name-position-in-error-messages (6ed9016) with main (e5b7fb2)}

Summary

✅ 4 untouched
⏩ 33 skipped¹

33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/react/jsx_handler_names.rs

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/react/jsx_handler_names.rs

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/react/jsx_handler_names.rs

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/react/jsx_handler_names.rs

…led before the check using this regex.

because the extracted handler name will not have the "props." part.

…r "props.*"

camc314

thank you!

## [1.21.0] - 2025-10-08 ### 🚀 Features - 576be20 linter/plugins: Support selectors DSL (#14435) (overlookmotel) - b2de44f linter/plugins: Support interpolation in normal diagnostic `message` (#14419) (overlookmotel) - 382c5be linter/plugins: Support placeholders in messageIds (#14416) (camc314) - 529e88e linter/plugins: Support `messageId`s (#14415) (camc314) - 83e7824 linter: Add `vue/require-default-export` rule (#14351) (Sysix) - ff98536 linter: Add `vue/no-import-compiler-macros` rule (#14335) (Sysix) - 0ec0847 ci: Run napi tests on windows (#14383) (camc314) ### 🐛 Bug Fixes - 11e0440 linter/jsx-handler-name: Improve handler name position in error messages (#14174) (Takuji Shimokawa) - 493082c language_server: Use the first Span of the message as the primary Diagnostic range (#14057) (Sysix) - 88ec1bd linter/plugins: Fix error messages (#14423) (overlookmotel) - 18616c2 oxlint: Ignore fixtures dir for vitest (#14414) (camc314) - ec02fe8 oxlint: Normalize path separators in snapshot tests (#14406) (camc314) - 6e8d2f6 language_server: Ignore JS plugins (#14379) (overlookmotel) - 96663fb linter/plugins: Do not call `before` hook if empty visitor (#14401) (overlookmotel) - 52f04bd linter: Use `pathToFileURL` for importing plugins to ensure correct URL format (#14394) (camc314) - 1ea0d46 oxlint: Resolve tsdown deprecation warning (#14389) (camc314) - bb679b5 linter: Promise/prefer-await-to-then strict option not reading from config (#14382) (camc314) ### 🚜 Refactor - 3374b8e linter/language_server: Move all lsp relevant code to `oxc_language_server` crate (#14430) (Sysix) - d24b74e linter/language_server: `oxc_linter::TsgoLinter::run_source` returns `Message` (#14429) (Sysix) - e5b7fb2 linter/language_server: `oxc_linter::Runtime::run_source` returns `Message` (#14428) (Sysix) - 3b26bf3 linter/plugins: Split adding visit function to compiler visitor into multiple functions (#14433) (overlookmotel) - af3a75e linter/plugins: Track ancestors while walking AST (#14432) (overlookmotel) - f279f0b linter/plugins: Do not lazy-load visitor keys (#14431) (overlookmotel) - 5e99ed3 linter/plugins: Allow nullish values as `message` or `messageId` (#14422) (overlookmotel) - dc30938 linter/plugins: Remove default value from `Context` constructor (#14421) (overlookmotel) - 28cfae0 oxlint: Use `vitest`s built in file snapshot comparison (#14392) (camc314) - 06b0e9f linter/plugins: Convert generated files to TS (#14385) (overlookmotel) - 52f35c6 napi/parser, linter/plugins: Rename `types.js` to `type_ids.js` (#14384) (overlookmotel) ### ⚡ Performance - 26435a1 linter/plugins: Small perf optimizations (#14420) (overlookmotel) - d8a8be1 linter/plugins: Avoid private methods (#14418) (overlookmotel) ### 🧪 Testing - d8da4a4 linter/plugins: Clarify tests for message placeholders (#14417) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

takuji requested a review from camc314 as a code owner September 27, 2025 04:10

Copilot AI review requested due to automatic review settings September 27, 2025 04:10

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Sep 27, 2025

Copilot AI reviewed Sep 27, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Outdated Show resolved Hide resolved

camc314 self-assigned this Sep 27, 2025

takuji requested a review from Copilot September 30, 2025 14:57

Copilot AI reviewed Sep 30, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Outdated Show resolved Hide resolved

takuji force-pushed the jsx-handler-names-improve-handler-name-position-in-error-messages branch from 72594b0 to 4af3a1a Compare October 1, 2025 22:41

takuji requested a review from Copilot October 1, 2025 22:45

Copilot AI reviewed Oct 1, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Outdated Show resolved Hide resolved

takuji force-pushed the jsx-handler-names-improve-handler-name-position-in-error-messages branch from 4af3a1a to 11f2e81 Compare October 2, 2025 15:20

takuji requested a review from Copilot October 2, 2025 15:26

Copilot AI reviewed Oct 2, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Show resolved Hide resolved

takuji force-pushed the jsx-handler-names-improve-handler-name-position-in-error-messages branch 2 times, most recently from 5748611 to 116260b Compare October 2, 2025 17:19

takuji requested a review from Copilot October 2, 2025 17:32

Copilot AI reviewed Oct 2, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_handler_names.rs Show resolved Hide resolved

takuji force-pushed the jsx-handler-names-improve-handler-name-position-in-error-messages branch from f9f431d to 1c77a4b Compare October 4, 2025 04:33

takuji added 5 commits October 8, 2025 12:14

improve the precision of the handler name position in error messages

805d544

remove "ref" from the prop name pattern because it is explicitly hand…

f39496f

…led before the check using this regex.

remove "props.({prop_prefix_pattern})" from the handler name pattern

182136c

because the extracted handler name will not have the "props." part.

allow the props name pattern only when the handler is "this.props.* o…

4caa3cb

…r "props.*"

add test cases for non-function values

6ed9016

camc314 force-pushed the jsx-handler-names-improve-handler-name-position-in-error-messages branch from 1c77a4b to 6ed9016 Compare October 8, 2025 11:14

camc314 approved these changes Oct 8, 2025

View reviewed changes

camc314 merged commit 11e0440 into oxc-project:main Oct 8, 2025
19 checks passed

Boshen mentioned this pull request Oct 8, 2025

release(oxlint): v1.21.0 #14441

Merged

Uh oh!

fix(linter/jsx-handler-name): improve handler name position in error messages #14174

fix(linter/jsx-handler-name): improve handler name position in error messages #14174

Uh oh!

Conversation

takuji commented Sep 27, 2025

Uh oh!

graphite-app bot commented Sep 27, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14174 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

camc314 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Sep 27, 2025 •

edited

Loading

camc314 left a comment •

edited

Loading