Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions crates/oxc_codegen/src/gen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2752,11 +2752,9 @@ impl Gen for AccessorProperty<'_> {
impl Gen for PrivateIdentifier<'_> {
fn r#gen(&self, p: &mut Codegen, _ctx: Context) {
let name = if let Some(class_index) = p.current_class_index()
&& let Some(mangled) = &p
.private_member_mappings
.as_ref()
.and_then(|m| m[class_index].get(self.name.as_str()))
{
&& let Some(mangled) = &p.private_member_mappings.as_ref().and_then(|m| {
m[0..=class_index].iter().rev().find_map(|m| m.get(self.name.as_str()))
}) {
(*mangled).clone()
} else {
self.name.into_compact_str()
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_minifier/tests/mangler/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ fn private_member_mangling() {
"class Foo { #x; check() { return #x in this; } }",
// Nested classes
"class Outer { #outerField = 1; inner() { return class Inner { #innerField = 2; get() { return this.#innerField; } }; } }",
"class Outer { #shared = 1; getInner() { let self = this; return class { method() { return self.#shared; } }; } }",
"class Outer { #shared = 1; getInner() { return class { #shared = 2; method() { return this.#shared; } }; } }",
// Mixed public and private
"class Foo { publicField = 1; #privateField = 2; getSum() { return this.publicField + this.#privateField; } }",
// Test same names across different classes should reuse mangled names
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,32 @@ class Outer {
}
}

class Outer { #shared = 1; getInner() { let self = this; return class { method() { return self.#shared; } }; } }
class Outer {
#e = 1;
getInner() {
let e = this;
return class {
method() {
return e.#e;
}
};
}
}

class Outer { #shared = 1; getInner() { return class { #shared = 2; method() { return this.#shared; } }; } }
class Outer {
#e = 1;
getInner() {
return class {
#e = 2;
method() {
return this.#e;
}
};
}
}

class Foo { publicField = 1; #privateField = 2; getSum() { return this.publicField + this.#privateField; } }
class Foo {
publicField = 1;
Expand Down
Loading