fix(mangler): mangle private class members used in nested classes properly

[sapphi-red]

fixes #14209
refs #14027

[sapphi-red]

• fix(mangler): mangle private class members used in nested classes properly #14218 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR fixes a bug where private class members used in nested classes were not being mangled properly. The fix ensures that when generating code for private identifiers, the mangler searches through all enclosing class scopes (from innermost to outermost) to find the correct mangled name, rather than only looking at the current class scope.

• Updates the private identifier code generation to search through all enclosing class scopes
• Adds test cases for nested classes that access outer class private members and handle name shadowing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_codegen/src/gen.rs	Modified private identifier generation to search through all enclosing class scopes
crates/oxc_minifier/tests/mangler/mod.rs	Added test cases for nested classes with private member access
crates/oxc_minifier/tests/mangler/snapshots/private_member_mangling.snap	Updated test snapshots with expected output for new test cases

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #14218 will not alter performance

_{Comparing 09-29-fix_mangler_mangle_private_class_members_used_in_nested_classes_properly (b83ffe5) with main (653aa8a)¹}

Summary

✅ 37 untouched

Footnotes

1. No successful run was found on main (b83ffe5) during the generation of this report, so 653aa8a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Boshen]

Merge activity

• Oct 1, 4:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 1, 4:54 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Oct 1, 5:00 AM UTC: Merged by the Graphite merge queue.