Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Sep 20, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 20, 2025 10:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the release process by replacing the custom cargo release-oxc publish --release crates command with the standard Cargo cargo publish --workspace command. This change standardizes the publishing workflow to use Cargo's built-in workspace publishing functionality.

  • Replaced custom release tool command with standard Cargo command
  • Applied the change consistently across both release and prepare release workflows

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release_crates.yml Updated actual release step to use cargo publish --workspace
.github/workflows/prepare_release_crates.yml Updated dry-run step to use cargo publish --workspace --dry-run

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author

Boshen commented Sep 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen merged commit 3ade441 into main Sep 20, 2025
21 checks passed
@Boshen Boshen deleted the 09-20-ci_release_use_the_cargo_publish_--workspace_directly branch September 20, 2025 12:07
Boshen added a commit that referenced this pull request Sep 22, 2025
…3943)"

`cargo publish --workspace` errors out when a crate is already
published, `cargo-release-oxc` does not. We sometimes need to retry the
whole publishing process when crates are published partially.

This reverts commit 3ade441.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants