fix(traverse): fix codegen #13192
fix(traverse): fix codegen #13192
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Merging without review, as this mistake (my mistake) has screwed everything up. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a non-deterministic codegen issue by reverting parallel processing back to sequential processing. The change ensures deterministic output from the traverse codegen by processing files one at a time instead of using Promise.all with concurrent processing.
- Reverts parallelization of file processing to prevent non-deterministic codegen output
- Adds oxlint disable comment to suppress the no-await-in-loop warning
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const types = Object.create(null); | ||
| await Promise.all(FILENAMES.map(async (filename) => { | ||
| for (const filename of FILENAMES) { | ||
| // oxlint-disable-next-line no-await-in-loop |
There was a problem hiding this comment.
The disable comment uses 'oxlint' but should likely be 'eslint' based on standard linting tool naming conventions.
| // oxlint-disable-next-line no-await-in-loop | |
| // eslint-disable-next-line no-await-in-loop |
Partially revert #13186. Linter had suggested to parallelize this code, but that was a bad idea as it makes the output of the codegen non-deterministic.