refactor(traverse): fix lint errors in codegen #13186
Conversation
github-actions
bot
added
the
C-cleanup
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the lint configuration and fixes lint errors in the oxc_traverse codegen scripts. The changes remove a file from the lint ignore list and address specific linting issues in the parse module.
- Remove
crates/oxc_traverse/scripts/lib/parse.mjsfrom the oxlint ignore list - Fix ESLint JSDoc and async/await patterns in the parse script
- Disable JSDoc property description requirement for codegen files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| oxlintrc.json | Removes parse.mjs from lint ignore list to enable linting |
| crates/oxc_traverse/scripts/lib/parse.mjs | Fixes lint violations with JSDoc disable comment, async patterns, and parameter documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
Fix lint errors in `oxc_traverse` codegen. It doesn't seem worthwhile adding descriptions to all properties of the type defs, since intention is to translate this codegen to Rust anyway. So just disable that rule.
graphite-app
bot
force-pushed
the
08-18-refactor_traverse_fix_lint_errors_in_codegen
branch
from
6431b63 to
72880a7
Compare
graphite-app
bot
deleted the
08-18-refactor_traverse_fix_lint_errors_in_codegen
branch
Partially revert #13186. Linter had suggested to parallelize this code, but that was a bad idea as it makes the output of the codegen non-deterministic.
Fix lint errors in
oxc_traversecodegen.It doesn't seem worthwhile adding descriptions to all properties of the type defs, since intention is to translate this codegen to Rust anyway. So just disable that rule.