Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 18, 2025

Codegen contains the same code for getting the bytes of PS and LS characters in multiple places. Remove this repetition by exporting the consts from str.rs module, and using them everywhere else.

@github-actions github-actions bot added A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 18, 2025
Copy link
Member Author

overlookmotel commented Aug 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025

CodSpeed Instrumentation Performance Report

Merging #13191 will not alter performance

Comparing 08-18-refactor_codegen_reduce_repeated_code (51ca0ad) with main (ada4e84)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (e3bfff1) during the generation of this report, so ada4e84 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the 08-18-refactor_codegen_reduce_repeated_code branch from 89ec4f9 to a65bf6e Compare August 18, 2025 14:49
@overlookmotel overlookmotel force-pushed the 08-18-perf_codegen_faster_splitting_comments_into_lines branch from e1bf875 to bffe03c Compare August 18, 2025 14:49
@overlookmotel overlookmotel marked this pull request as ready for review August 18, 2025 14:52
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 19, 2025
Copy link
Member

Boshen commented Aug 19, 2025

Merge activity

Codegen contains the same code for getting the bytes of `PS` and `LS` characters in multiple places. Remove this repetition by exporting the consts from `str.rs` module, and using them everywhere else.
@graphite-app graphite-app bot force-pushed the 08-18-perf_codegen_faster_splitting_comments_into_lines branch from bffe03c to e3bfff1 Compare August 19, 2025 00:33
@graphite-app graphite-app bot force-pushed the 08-18-refactor_codegen_reduce_repeated_code branch from a65bf6e to 51ca0ad Compare August 19, 2025 00:33
Base automatically changed from 08-18-perf_codegen_faster_splitting_comments_into_lines to main August 19, 2025 00:38
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 19, 2025
@graphite-app graphite-app bot merged commit 51ca0ad into main Aug 19, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-18-refactor_codegen_reduce_repeated_code branch August 19, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants