Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 15, 2025

Reverse-transpile rest argument code generated by TypeScript and babel.

Example input:

for (var e = arguments.length, r = Array(e), a = 0; a < e; a++)
  r[a] = arguments[a];

output:

var r = [...arguments];

It's a quite specific transform though.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Aug 15, 2025
Copy link
Member Author

sapphi-red commented Aug 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed Instrumentation Performance Report

Merging #13114 will not alter performance

Comparing 08-15-feat_minifier_rewrite_arguments_copy_loops_to_spread_syntax (3d0d31a) with main (c661bac)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (3d0d31a) during the generation of this report, so c661bac was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red marked this pull request as ready for review August 15, 2025 09:23
@graphite-app graphite-app bot changed the base branch from 08-15-fix_minifier_keep_array_reference_id_when_compressing_array_ to graphite-base/13114 August 15, 2025 11:25
@graphite-app graphite-app bot force-pushed the graphite-base/13114 branch from f845070 to 896c3ba Compare August 15, 2025 11:33
@graphite-app graphite-app bot force-pushed the 08-15-feat_minifier_rewrite_arguments_copy_loops_to_spread_syntax branch from 8863890 to 9f0367e Compare August 15, 2025 11:33
@graphite-app graphite-app bot changed the base branch from graphite-base/13114 to main August 15, 2025 11:34
@graphite-app graphite-app bot force-pushed the 08-15-feat_minifier_rewrite_arguments_copy_loops_to_spread_syntax branch from 9f0367e to ff1d148 Compare August 15, 2025 11:34
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 15, 2025

Merge activity

Reverse-transpile rest argument code generated by TypeScript and babel.

Example input:
```js
for (var e = arguments.length, r = Array(e), a = 0; a < e; a++)
  r[a] = arguments[a];
```
output:
```js
var r = [...arguments];
```

It's a quite specific transform though.
@graphite-app graphite-app bot force-pushed the 08-15-feat_minifier_rewrite_arguments_copy_loops_to_spread_syntax branch from ff1d148 to 3d0d31a Compare August 15, 2025 13:04
Copilot AI review requested due to automatic review settings August 15, 2025 13:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 3d0d31a into main Aug 15, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
@graphite-app graphite-app bot deleted the 08-15-feat_minifier_rewrite_arguments_copy_loops_to_spread_syntax branch August 15, 2025 13:09
graphite-app bot pushed a commit that referenced this pull request Oct 15, 2025
…porary variables are referenced outside the for loop (#14613)

fixes rolldown/rolldown#6458
refs #13114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants