Skip to content

fix(minifier): improve quoted property key handling for class methods and properties #12999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2025
Merged

fix(minifier): improve quoted property key handling for class methods and properties #12999

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
523ab29
Initial plan
Copilot Aug 11, 2025
f86b5f2
Initial analysis and test case for constructor minification issue
Copilot Aug 11, 2025
8c56faa
Fix minifier to remove quotes around "constructor" as class method key
Copilot Aug 11, 2025
924e7d4
Fix clippy linting warning about collapsible if
Copilot Aug 11, 2025
98545ca
Move constructor tests to substitute_alternate_syntax.rs and fix prop…
Copilot Aug 11, 2025
4eb00a4
Revert test changes and add specific prototype/constructor test cases
Copilot Aug 11, 2025
1ebbdb0
Move tests to proper location in arai-a comment section
Copilot Aug 11, 2025
9d547f8
fix(minifier): fix clippy collapsible_if warning and apply prop.compu…
Copilot Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,12 @@ impl<'a> PeepholeOptimizations {
ctx: &mut Ctx<'a, '_>,
) {
let property_key_parent: ClassPropertyKeyParent = prop.into();
if let PropertyKey::StringLiteral(str) = &prop.key {
if property_key_parent.should_keep_as_computed_property(&str.value) {
return;
}
// Only check for computed property restrictions if this is actually a computed property
if prop.computed
&& let PropertyKey::StringLiteral(str) = &prop.key
&& property_key_parent.should_keep_as_computed_property(&str.value)
{
return;
}
self.try_compress_property_key(&mut prop.key, &mut prop.computed, ctx);
}
Expand All @@ -104,10 +106,12 @@ impl<'a> PeepholeOptimizations {
ctx: &mut Ctx<'a, '_>,
) {
let property_key_parent: ClassPropertyKeyParent = prop.into();
if let PropertyKey::StringLiteral(str) = &prop.key {
if property_key_parent.should_keep_as_computed_property(&str.value) {
return;
}
// Only check for computed property restrictions if this is actually a computed property
if prop.computed
&& let PropertyKey::StringLiteral(str) = &prop.key
&& property_key_parent.should_keep_as_computed_property(&str.value)
{
return;
}
self.try_compress_property_key(&mut prop.key, &mut prop.computed, ctx);
}
Expand All @@ -118,10 +122,12 @@ impl<'a> PeepholeOptimizations {
ctx: &mut Ctx<'a, '_>,
) {
let property_key_parent: ClassPropertyKeyParent = prop.into();
if let PropertyKey::StringLiteral(str) = &prop.key {
if property_key_parent.should_keep_as_computed_property(&str.value) {
return;
}
// Only check for computed property restrictions if this is actually a computed property
if prop.computed
&& let PropertyKey::StringLiteral(str) = &prop.key
&& property_key_parent.should_keep_as_computed_property(&str.value)
{
return;
}
self.try_compress_property_key(&mut prop.key, &mut prop.computed, ctx);
}
Expand Down Expand Up @@ -1734,19 +1740,23 @@ mod test {
test_same("class C { static ['prototype'] = 0 }"); // class C { prototype = 0 } is an early error
test_same("class C { static accessor ['prototype'] = 0 }"); // class C { accessor prototype = 0 } is an early error
test("class C { ['prototype']() {} }", "class C { prototype() {} }");
test("class C { 'prototype'() {} }", "class C { prototype() {} }");
test("class C { ['prototype'] = 0 }", "class C { prototype = 0 }");
test("class C { 'prototype' = 0 }", "class C { prototype = 0 }");
test("class C { accessor ['prototype'] = 0 }", "class C { accessor prototype = 0 }");
test_same("class C { ['constructor'] = 0 }"); // class C { constructor = 0 } is an early error
test_same("class C { accessor ['constructor'] = 0 }"); // class C { accessor constructor = 0 } is an early error
test_same("class C { static ['constructor'] = 0 }"); // class C { static constructor = 0 } is an early error
test_same("class C { static accessor ['constructor'] = 0 }"); // class C { static accessor constructor = 0 } is an early error
test_same("class C { ['constructor']() {} }"); // computed `constructor` is not treated as a constructor
test("class C { 'constructor'() {} }", "class C { constructor() {} }");
test_same("class C { *['constructor']() {} }"); // class C { *constructor() {} } is an early error
test_same("class C { async ['constructor']() {} }"); // class C { async constructor() {} } is an early error
test_same("class C { async *['constructor']() {} }"); // class C { async *constructor() {} } is an early error
test_same("class C { get ['constructor']() {} }"); // class C { get constructor() {} } is an early error
test_same("class C { set ['constructor'](v) {} }"); // class C { set constructor(v) {} } is an early error
test("class C { static ['constructor']() {} }", "class C { static constructor() {} }");
test("class C { static 'constructor'() {} }", "class C { static constructor() {} }");
test_same("class C { ['#constructor'] = 0 }"); // class C { #constructor = 0 } is an early error
test_same("class C { accessor ['#constructor'] = 0 }"); // class C { accessor #constructor = 0 } is an early error
test_same("class C { ['#constructor']() {} }"); // class C { #constructor() {} } is an early error
Expand Down
Loading