fix(minifier): improve quoted property key handling for class methods and properties

[Copilot]

The minifier was not consistently removing quotes around property keys in class definitions. The issue affected both method definitions and property/accessor definitions, where quoted strings like "constructor" should be converted to unquoted identifiers when safe to do so.

Problem

The minifier had inconsistent behavior with quoted property keys:

// Method definitions - partially working
class C { "constructor"() {} }     // ❌ Not converted
class C { "method"() {} }          // ✅ Converted to method()

// Property definitions - not working  
class C { "prop" = value }         // ❌ Not converted
class C { accessor "prop" = value } // ❌ Not converted

Root Cause

The should_keep_as_computed_property check was being applied to all string literal keys, not just computed properties. This caused the minifier to incorrectly treat quoted strings ("key") the same as computed properties (['key']), when they have different semantics and conversion rules.

Solution

Fixed by modifying the condition in substitute_method_definition, substitute_property_definition, and substitute_accessor_property to only apply computed property restrictions when prop.computed is true:

// Before (buggy)
if let PropertyKey::StringLiteral(str) = &prop.key {
    if property_key_parent.should_keep_as_computed_property(&str.value) {
        return;
    }
}

// After (fixed)
if prop.computed
    && let PropertyKey::StringLiteral(str) = &prop.key
    && property_key_parent.should_keep_as_computed_property(&str.value)
{
    return;
}

This ensures proper handling of:

• String literals ("constructor") → converted to unquoted identifiers when safe
• Computed properties (['constructor']) → preserved based on semantic rules to avoid early errors

Results

• class C { "constructor"() {} } → class C { constructor() {} } ✅
• class C { static "constructor"() {} } → class C { static constructor() {} } ✅
• class C { "method"() {} } → class C { method() {} } ✅
• class C { ['constructor']() {} } → stays unchanged ✅ (computed property preserved)
• class C { static ['constructor']() {} } → class C { static constructor() {} } ✅

Fixes #12992.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

@Boshen 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[Boshen]

Pretty insane that AI got all the right context.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12999 will not alter performance

_{Comparing copilot/fix-12992 (9d547f8) with main (ca91a26)}

Summary

✅ 34 untouched benchmarks

[Copilot]

Pull Request Overview

This PR fixes a bug in the minifier where quoted "constructor" class method keys were not being converted to unquoted identifiers, missing an optimization opportunity. The issue was that the minifier incorrectly treated string literal keys the same as computed property keys when determining whether to preserve quotes.

Key changes:

• Modified the conditional logic in substitute_method_definition to only check computed property restrictions for actual computed properties
• Added comprehensive test cases to verify the fix works for various method types and scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs	Fixed the buggy condition that was preventing quoted constructor methods from being optimized
crates/oxc_minifier/src/peephole/convert_to_dotted_properties.rs	Added test cases to verify the fix and prevent regressions

[sapphi-red]

@copilot fix clippy failure

[Copilot]

@copilot fix clippy failure

Fixed the clippy collapsible_if warning by collapsing the nested if statement and also applied the consistent prop.computed check to all three property methods (substitute_method_definition, substitute_property_definition, and substitute_accessor_property). All tests pass and clippy warnings are resolved. Fixed in commit 9d547f8.