Skip to content

refactor(codegen): remove the redundant base_len variable #12882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2025
Merged

refactor(codegen): remove the redundant base_len variable #12882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions crates/oxc_codegen/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,17 +774,15 @@ impl<'a> Codegen<'a> {
}

let mut best_candidate = s.cow_replacen("e+", "e", 1);
let mut best_len = best_candidate.len();
let mut is_hex = false;

// Track the best candidate found so far
if num.fract() == 0.0 {
// For integers, check hex format and other optimizations
let hex_candidate = format!("0x{:x}", num as u128);
if hex_candidate.len() < best_len {
if hex_candidate.len() < best_candidate.len() {
is_hex = true;
best_candidate = hex_candidate.into();
best_len = best_candidate.len();
}
}
// Check for scientific notation optimizations for numbers starting with ".0"
Expand All @@ -797,10 +795,9 @@ impl<'a> Codegen<'a> {
let exp_str_len = itoa::Buffer::new().format(exp).len();
// Calculate expected length: digits + 'e-' + exp_length
let expected_len = digits.len() + 2 + exp_str_len;
if expected_len < best_len {
if expected_len < best_candidate.len() {
best_candidate = format!("{digits}e-{exp}").into();
debug_assert_eq!(best_candidate.len(), expected_len);
best_len = best_candidate.len();
}
}
}
Expand All @@ -814,10 +811,9 @@ impl<'a> Codegen<'a> {
let exp_str_len = itoa::Buffer::new().format(len).len();
// Calculate expected length: base + 'e' + len
let expected_len = base.len() + 1 + exp_str_len;
if expected_len < best_len {
if expected_len < best_candidate.len() {
best_candidate = format!("{base}e{len}").into();
debug_assert_eq!(best_candidate.len(), expected_len);
best_len = expected_len;
}
}
}
Expand All @@ -831,7 +827,7 @@ impl<'a> Codegen<'a> {
let new_exp_str_len = itoa::Buffer::new().format(new_expr).len();
// Calculate expected length: integer + point + 'e' + new_exp_str_len
let expected_len = integer.len() + point.len() + 1 + new_exp_str_len;
if expected_len < best_len {
if expected_len < best_candidate.len() {
best_candidate = format!("{integer}{point}e{new_expr}").into();
debug_assert_eq!(best_candidate.len(), expected_len);
}
Expand Down
Loading