Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 7, 2025

A follow-up of #12847. I just noticed base_len is redundant

Copy link
Member Author

Dunqing commented Aug 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025

CodSpeed Instrumentation Performance Report

Merging #12882 will not alter performance

Comparing 08-07-refactor_codegen_remove_the_redundant_base_len_variable (c48ee4f) with main (248fd94)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (bfacd66) during the generation of this report, so 248fd94 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen merged commit f6475e1 into main Aug 10, 2025
31 checks passed
@Boshen Boshen deleted the 08-07-refactor_codegen_remove_the_redundant_base_len_variable branch August 10, 2025 07:18
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants