fix(tasks): propagate io::copy errors during benchmark file download #12813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12813 will not alter performanceComparing Summary
|
Boshen
deleted the
c/08-04-fix_tasks_propagate_io_copy_errors_during_benchmark_file_download
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…xc-project#12813) Codspeed left this comment on my PR. The perf increase is obviously wrong, the only way i could see this happening is if it failed to copy. this PR updates it to propogate the error so that we know when something fails, rather than having codspeed log incorrect perf differences 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codspeed left this comment on my PR.
The perf increase is obviously wrong, the only way i could see this happening is if it failed to copy. this PR updates it to propogate the error so that we know when something fails, rather than having codspeed log incorrect perf differences