Skip to content

Commit 13f0658

Browse files
authored
fix(tasks): propagate io::copy errors during benchmark file download (#12813)
Codspeed left this comment on my PR. The perf increase is obviously wrong, the only way i could see this happening is if it failed to copy. this PR updates it to propogate the error so that we know when something fails, rather than having codspeed log incorrect perf differences ![Screenshot 2025-08-04 at 20.03.10.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/8ASanJZ3iQ7b9iVhlds7/ff7af92c-a344-477b-862c-06b1ebebef4a.png)
1 parent 69fd08d commit 13f0658

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tasks/common/src/test_file.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ impl TestFile {
113113

114114
let _drop = std::fs::remove_file(&file);
115115
let mut writer = std::fs::File::create(&file).map_err(err_to_string)?;
116-
let _drop = std::io::copy(&mut reader, &mut writer);
116+
std::io::copy(&mut reader, &mut writer).map_err(err_to_string)?;
117117

118118
std::fs::read_to_string(&file)
119119
.map_err(err_to_string)

0 commit comments

Comments
 (0)