Skip to content

refactor(editor): split Config to VSCodeConfig and WorkspaceConfig #10572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

refactor(editor): split Config to VSCodeConfig and WorkspaceConfig #10572

merged 1 commit into from
Apr 25, 2025

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Apr 23, 2025

No description provided.

@Sysix Sysix mentioned this pull request Apr 23, 2025
Merged
@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 23, 2025
This was referenced Apr 23, 2025
Merged
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented Apr 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request Apr 23, 2025
Closed
@Sysix Sysix force-pushed the 04-23-refactor_editor_split_config_to_vscodeconfig_and_workspaceconfig branch 5 times, most recently from fe32165 to e9e176a Compare April 23, 2025 18:24
@Sysix Sysix marked this pull request as ready for review April 23, 2025 19:08
@Sysix Sysix force-pushed the 04-18-feat_language_server_support_multiple_workspaces branch from 31b5867 to 5e67e03 Compare April 23, 2025 19:16
@Sysix Sysix force-pushed the 04-23-refactor_editor_split_config_to_vscodeconfig_and_workspaceconfig branch from e9e176a to 284836b Compare April 23, 2025 19:16
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Apr 24, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Apr 23, 11:23 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 23, 11:26 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Apr 23, 11:29 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Apr 25, 8:38 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 25, 8:41 AM EDT: Sysix added this pull request to the Graphite merge queue.
  • Apr 25, 8:46 AM EDT: Merged by the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
@graphite-app graphite-app bot changed the base branch from 04-18-feat_language_server_support_multiple_workspaces to graphite-base/10572 April 24, 2025 03:29
@Sysix Sysix force-pushed the 04-23-refactor_editor_split_config_to_vscodeconfig_and_workspaceconfig branch from 284836b to 52bfc01 Compare April 24, 2025 16:49
@Sysix Sysix force-pushed the graphite-base/10572 branch from 5e67e03 to dcf718f Compare April 24, 2025 16:49
@Sysix Sysix changed the base branch from graphite-base/10572 to main April 24, 2025 16:49
@Sysix Sysix force-pushed the 04-23-refactor_editor_split_config_to_vscodeconfig_and_workspaceconfig branch from 52bfc01 to d9a77d9 Compare April 25, 2025 12:36
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
@graphite-app graphite-app bot force-pushed the 04-23-refactor_editor_split_config_to_vscodeconfig_and_workspaceconfig branch from d9a77d9 to e903ba2 Compare April 25, 2025 12:42
@graphite-app graphite-app bot merged commit e903ba2 into main Apr 25, 2025
19 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
@graphite-app graphite-app bot deleted the 04-23-refactor_editor_split_config_to_vscodeconfig_and_workspaceconfig branch April 25, 2025 12:46
@oxc-bot oxc-bot mentioned this pull request Apr 27, 2025
Merged
@Sysix Sysix mentioned this pull request Apr 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camchenry camchenry camchenry approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sysix @Boshen @camchenry