refactor(language_server): make linter independent of Backend
#10497
+696
−522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10497 will not alter performanceComparing Summary
|
Sysix
changed the base branch from
04-17-refactor_language_server_move_code_actions_into_own_file
to
graphite-base/10497
Sysix
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
from
73faf0d to
1a46000
Compare
Sysix
changed the base branch from
graphite-base/10497
to
04-19-refactor_language_server_do_not_request_for_worspace_configuration_when_the_client_does_not_support_it
Sysix
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
9 times, most recently
from
6123ff4 to
a3d554d
Compare
Sysix
changed the title
Backend
github-actions
bot
added
the
C-cleanup
Sysix
force-pushed
the
04-19-refactor_language_server_do_not_request_for_worspace_configuration_when_the_client_does_not_support_it
branch
from
ebafe04 to
246d6dc
Compare
Sysix
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
from
a3d554d to
ef3d0b1
Compare
graphite-app
bot
changed the base branch from
04-19-refactor_language_server_do_not_request_for_worspace_configuration_when_the_client_does_not_support_it
to
graphite-base/10497
Sysix
force-pushed
the
graphite-base/10497
branch
from
246d6dc to
db05a15
Compare
Sysix
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
from
ef3d0b1 to
94f0d9d
Compare
Sysix
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
from
94f0d9d to
224d614
Compare
Sysix
commented
Apr 22, 2025
Sysix
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
2 times, most recently
from
327d41f to
31b5867
Compare
Sysix
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
from
31b5867 to
5e67e03
Compare
camchenry
approved these changes
Apr 23, 2025
Member
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
I need to get a better handle on the language server protocol, but I think this makes sense
Contributor
Merge activity
|
This PR will refactor the language server, so the Linter is independent of the language server. The changes are needed to support multiple workspaces in the upstream PR. There, every linter will get its own root Uri, and will report back to the `Backend`. The `Backend` collects the different outputs from the workers and return them to the client when needed.
graphite-app
bot
force-pushed
the
04-18-feat_language_server_support_multiple_workspaces
branch
from
5e67e03 to
f6c6969
Compare
graphite-app
bot
deleted the
04-18-feat_language_server_support_multiple_workspaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will refactor the language server, so the Linter is independent of the language server.
The changes are needed to support multiple workspaces in the upstream PR.
There, every linter will get its own root Uri, and will report back to the
Backend.The
Backendcollects the different outputs from the workers and return them to the client when needed.