Skip to content

Don't reload resources when going to a different page on the same route/resource #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kulmann merged 1 commit into from
Jun 21, 2021
Merged

Don't reload resources when going to a different page on the same route/resource #5309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changelog/unreleased/enhancement-add-pagination
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ Enhancement: Add pagination

We've added pagination to all files lists. Current limit for displayed resources is 100.

https://github.com/owncloud/web/pull/5224
https://github.com/owncloud/web/pull/5224
https://github.com/owncloud/web/pull/5309
8 changes: 6 additions & 2 deletions packages/web-app-files/src/views/LocationPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,12 @@ export default {

watch: {
$route: {
handler: function() {
this.navigateToTarget(this.$route)
handler: function(to, from) {
const sameRoute = to.name === from?.name
const sameItem = to.params?.item === from?.params?.item
if (!sameRoute || !sameItem) {
this.navigateToTarget(this.$route)
}
this.$_filesListPagination_updateCurrentPage()
},
immediate: true
Expand Down
5 changes: 4 additions & 1 deletion packages/web-app-files/src/views/Personal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,10 @@ export default {
}

const sameRoute = to.name === from?.name
this.loadResources(sameRoute)
const sameItem = to.params?.item === from?.params?.item
if (!sameRoute || !sameItem) {
this.loadResources(sameRoute)
}
this.$_filesListPagination_updateCurrentPage()
},
immediate: true
Expand Down
5 changes: 4 additions & 1 deletion packages/web-app-files/src/views/PublicFiles.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ export default {
$route: {
handler: function(to, from) {
const sameRoute = to.name === from?.name
this.loadResources(sameRoute)
const sameItem = to.params?.item === from?.params?.item
if (!sameRoute || !sameItem) {
this.loadResources(sameRoute)
}
this.$_filesListPagination_updateCurrentPage()
},
immediate: true
Expand Down