Don't reload resources when going to a different page on the same route/resource #5309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
changed the title
fschade
reviewed
Jun 18, 2021
Contributor
💥 Acceptance tests webUISharingNotifications failed. The build is cancelled... |
kulmann
force-pushed
the
dont-reload-on-pagination
branch
from
34f610b to
4719a53
Compare
Contributor
💥 Acceptance tests webUIOCISFiles2 failed. The build is cancelled... |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an implementation detail of the pagination that we brought in #5224: on pagination the resources were reloaded entirely. If the set of resources didn't change (which can be expected when only the page number is different to the route from before) this is unnecessary network traffic.
Motivation and Context
Performance
Types of changes
Checklist: